[GitHub] [systemds] j143 opened a new pull request, #1620: generate proto file

[GitBox <gi...@apache.org>]

j143 opened a new pull request, #1620:
URL: https://github.com/apache/systemds/pull/1620

   
   discussion points:
   1. the generated java file is not taking the license header
   2. Content seems to be a bit different from the older version of generated java file. (is there a way to test it)
   3. Is this generation step going to happen every time we run `mvn package`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] j143 merged pull request #1620: generate proto file

[GitBox <gi...@apache.org>]

j143 merged PR #1620:
URL: https://github.com/apache/systemds/pull/1620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1620: generate proto file

[GitBox <gi...@apache.org>]

Baunsgaard commented on PR #1620:
URL: https://github.com/apache/systemds/pull/1620#issuecomment-1133643944

   overall i think this seems nice.
   We can just add that license is not needed in this file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org