[GitHub] [orc] wgtmac commented on a change in pull request #975: ORC-1055: [C++] Add the timezone option for the csv-import tool

[GitBox <gi...@apache.org>]

wgtmac commented on a change in pull request #975:
URL: https://github.com/apache/orc/pull/975#discussion_r775935479



##########
File path: tools/src/CSVFileImport.cc
##########
@@ -280,15 +280,19 @@ void usage() {
             << "                  [-s <size>] [--stripe=<size>]\n"
             << "                  [-c <size>] [--block=<size>]\n"
             << "                  [-b <size>] [--batch=<size>]\n"
+            << "                  [-t <string>] [--timezone=<string>]\n"
             << "                  <schema> <input> <output>\n"
             << "Import CSV file into an Orc file using the specified schema.\n"
+            << "The timezone can be viewed in the directory /usr/share/zoneinfo\n"

Review comment:
       - It should be stated clearly that the timezone is writer timezone of timestamp types.
   - You have specified it as a **required_argument** which conflicts with the comment here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org