You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/27 06:15:05 UTC

[GitHub] [iotdb] Beyyes commented on a diff in pull request #7400: [IOTDB-4378] Negtive feedback Region extension policy

Beyyes commented on code in PR #7400:
URL: https://github.com/apache/iotdb/pull/7400#discussion_r980713721


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java:
##########
@@ -517,11 +517,16 @@ public void startHeartbeatService() {
 
   /** loop body of the heartbeat thread */
   private void heartbeatLoopBody() {
-    // the consensusManager of configManager may not be fully initialized at this time
+    // The consensusManager of configManager may not be fully initialized at this time
     Optional.ofNullable(getConsensusManager())
         .ifPresent(
             consensusManager -> {
               if (getConsensusManager().isLeader()) {
+                List<TConfigNodeLocation> registeredConfigNodes = getRegisteredConfigNodes();

Review Comment:
   These variables are never used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org