[GitHub] [ozone] ChenSammi commented on a diff in pull request #5030: HDDS-8593. Add RootCARotationPoller to CertClient

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on code in PR #5030:
URL: https://github.com/apache/ozone/pull/5030#discussion_r1255361913


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -183,6 +185,17 @@ private synchronized void loadAllCertificates() {
       getLogger().info("CertificateLifetimeMonitor is disabled for {}",
           component);
     }
+    startRootCaRotationPoller();

Review Comment:
   SCMCertificateClient doesn't need this poller.  You can move this under line 174 if statement. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org