You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "kasjer (via GitHub)" <gi...@apache.org> on 2026/08/10 18:06:03 UTC
[PR] Revert "shell: Fix LINK_TABLE start pointer alignment in shell module… [mynewt-core]
kasjer opened a new pull request, #3723:
URL: https://github.com/apache/mynewt-core/pull/3723
#3711 turned out to be not correct solution.
While it works for native Linux 64-bit build, is breaks normal target builds.
It's true that affected table element is 32 bytes long. But size of this structure is not the reason why elements are aligned to 32 bytes so manual alignment to structure size is unfortunately wrong solution.
For 32 bit ARM builds this alignment does not happen.
Working on other solution for this...
This reverts commit 1431593f7a2c46c71edd9d3b4e4d11db7ee037bb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "shell: Fix LINK_TABLE start pointer alignment in shell module… [mynewt-core]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer merged PR #3723:
URL: https://github.com/apache/mynewt-core/pull/3723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "shell: Fix LINK_TABLE start pointer alignment in shell module… [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #3723:
URL: https://github.com/apache/mynewt-core/pull/3723#issuecomment-5244465998
@stenslae FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org