You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Hadrian Zbarcea <hz...@gmail.com> on 2016/10/23 01:48:42 UTC
Many old open PRs
There are a number of old, even very old, PRs open [1]. Some I suspect
are not relevant anymore. It'd be great if somebody could look into them
and close them down. I will try to find some time next week and help
with that as well.
Cheers,
Hadrian
[1] https://github.com/apache/activemq/pulls
Re: Many old open PRs
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
I have been worked a bit lately to merge / close etc old PRs and got a
bunch done today.
We are down to 18 on activemq
https://github.com/apache/activemq/pulls
There are some which is more hardcore about transport connectors /
threading model etc that Gary and other long term AMQ hackers would be
best to just take a look and provide a few comments.
There are also some which are changes to the bin scripts which I dont
dare changing. They can be hard to test on all those different linux
distributions out there. And the current scripts has been working good
for most people.
Feedback and comments on the existing PR is welcome.
There is likely a bunch of outdated we can close, instead of leaving
PRs hanging for years and years.
We just cleaned up Camel recently and we are down to 8 open PRs that
are being worked at.
On Sun, Oct 23, 2016 at 3:48 AM, Hadrian Zbarcea <hz...@gmail.com> wrote:
> There are a number of old, even very old, PRs open [1]. Some I suspect are
> not relevant anymore. It'd be great if somebody could look into them and
> close them down. I will try to find some time next week and help with that
> as well.
>
> Cheers,
> Hadrian
>
> [1] https://github.com/apache/activemq/pulls
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: Many old open PRs
Posted by Hadrian Zbarcea <hz...@gmail.com>.
Nah, replied to your mail because the rest of the thread went into ideas
on how to close PRs.
I assume you have better things to do in beam-land :).
Cheers,
Hadrian
On 11/01/2016 02:12 AM, Jean-Baptiste Onofr� wrote:
> Hi Hadrian,
>
> Please, let me know if you need some help there.
>
> Regards
> JB
>
> On 11/01/2016 02:12 AM, Hadrian Zbarcea wrote:
>> Started to look into old PRs, some should not be merged. I'll see if I
>> could sort it out with infra to get them closed without a commit,
>> although imho, a commit like "This closes #xxx. Intentionally not
>> merged" is better, as it would show that the close without merge was
>> intentional.
>>
>> Another issue is that the build system looks like is in need of a bit of
>> love, some outdated and inconsistent dependencies for plugins. I fixed a
>> few, a few more that need a closer attentions. I saw that cshannon
>> merged a PR, I looked at it too, but I am not sure how it was tested as
>> many test fail intermittently, some just fail and jenkins didn't have a
>> clean build in a while. I'll look into those too.
>>
>> Cheers,
>> Hadrian
>>
>> On 10/23/2016 02:11 AM, Jean-Baptiste Onofr� wrote:
>>> Good idea Hadrian.
>>>
>>> I will try to take a look.
>>>
>>> Regards
>>> JB
>>>
>>> \u2063\u200b
>>>
>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com>
>>> wrote:
>>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>>> are not relevant anymore. It'd be great if somebody could look into
>>>> them
>>>> and close them down. I will try to find some time next week and help
>>>> with that as well.
>>>>
>>>> Cheers,
>>>> Hadrian
>>>>
>>>> [1] https://github.com/apache/activemq/pulls
>>>
>
Re: Many old open PRs
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Hadrian,
Please, let me know if you need some help there.
Regards
JB
On 11/01/2016 02:12 AM, Hadrian Zbarcea wrote:
> Started to look into old PRs, some should not be merged. I'll see if I
> could sort it out with infra to get them closed without a commit,
> although imho, a commit like "This closes #xxx. Intentionally not
> merged" is better, as it would show that the close without merge was
> intentional.
>
> Another issue is that the build system looks like is in need of a bit of
> love, some outdated and inconsistent dependencies for plugins. I fixed a
> few, a few more that need a closer attentions. I saw that cshannon
> merged a PR, I looked at it too, but I am not sure how it was tested as
> many test fail intermittently, some just fail and jenkins didn't have a
> clean build in a while. I'll look into those too.
>
> Cheers,
> Hadrian
>
> On 10/23/2016 02:11 AM, Jean-Baptiste Onofr� wrote:
>> Good idea Hadrian.
>>
>> I will try to take a look.
>>
>> Regards
>> JB
>>
>> \u2063\u200b
>>
>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com>
>> wrote:
>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>> are not relevant anymore. It'd be great if somebody could look into
>>> them
>>> and close them down. I will try to find some time next week and help
>>> with that as well.
>>>
>>> Cheers,
>>> Hadrian
>>>
>>> [1] https://github.com/apache/activemq/pulls
>>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Many old open PRs
Posted by Hadrian Zbarcea <hz...@gmail.com>.
I know all that and mostly agree. The PR you merged was ok, I know that;
as I am a bit anal about testing, and testing takes a few seconds less
than forever for activemq you beat me to it. Unnecessarily long testing
time is a problem and inconsistency is another. I have a bit of spare
time on my hands, I'll see if there's anything I could do to help.
Cheers,
Hadrian
On 11/01/2016 10:15 AM, Christopher Shannon wrote:
> Having a couple of build failures is not a problem when Jenkins runs
> because it is configured to run through all tests regardless of any
> failures. So while there are a handful of broken tests at any given time,
> the other 8 or 9 thousand tests still run consistently. There is currently
> one real OSGi failure right now but most of the failures are just tests
> that need to be fixed because they are intermittently failing. Also, the
> PR I merged was a new JNDI related class that had its own test. No where
> else was that class instantiated so no other test would fail anyways.
>
> On Mon, Oct 31, 2016 at 9:12 PM, Hadrian Zbarcea <hz...@gmail.com> wrote:
>
>> Started to look into old PRs, some should not be merged. I'll see if I
>> could sort it out with infra to get them closed without a commit, although
>> imho, a commit like "This closes #xxx. Intentionally not merged" is better,
>> as it would show that the close without merge was intentional.
>>
>> Another issue is that the build system looks like is in need of a bit of
>> love, some outdated and inconsistent dependencies for plugins. I fixed a
>> few, a few more that need a closer attentions. I saw that cshannon merged a
>> PR, I looked at it too, but I am not sure how it was tested as many test
>> fail intermittently, some just fail and jenkins didn't have a clean build
>> in a while. I'll look into those too.
>>
>> Cheers,
>> Hadrian
>>
>>
>> On 10/23/2016 02:11 AM, Jean-Baptiste Onofr� wrote:
>>
>>> Good idea Hadrian.
>>>
>>> I will try to take a look.
>>>
>>> Regards
>>> JB
>>>
>>> \u2063\u200b
>>>
>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com>
>>> wrote:
>>>
>>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>>> are not relevant anymore. It'd be great if somebody could look into
>>>> them
>>>> and close them down. I will try to find some time next week and help
>>>> with that as well.
>>>>
>>>> Cheers,
>>>> Hadrian
>>>>
>>>> [1] https://github.com/apache/activemq/pulls
>>>>
>>>
>>>
>
Re: Many old open PRs
Posted by Christopher Shannon <ch...@gmail.com>.
As a follow up, I ran through some of the current failures to see if there
were any new failing tests as I'd like to do a 5.14.2 release some point
soon. Most of them still seem to be of the intermittent failure type and
only occasionally fail or they pass locally for me and don't break at all
so they may take a little time to debug. Tim Bish and I have already fixed
several of these types of tests but haven't gotten to all of them yet.
(plus new ones always seem to pop up)
On Tue, Nov 1, 2016 at 10:15 AM, Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:
> Having a couple of build failures is not a problem when Jenkins runs
> because it is configured to run through all tests regardless of any
> failures. So while there are a handful of broken tests at any given time,
> the other 8 or 9 thousand tests still run consistently. There is currently
> one real OSGi failure right now but most of the failures are just tests
> that need to be fixed because they are intermittently failing. Also, the
> PR I merged was a new JNDI related class that had its own test. No where
> else was that class instantiated so no other test would fail anyways.
>
> On Mon, Oct 31, 2016 at 9:12 PM, Hadrian Zbarcea <hz...@gmail.com>
> wrote:
>
>> Started to look into old PRs, some should not be merged. I'll see if I
>> could sort it out with infra to get them closed without a commit, although
>> imho, a commit like "This closes #xxx. Intentionally not merged" is better,
>> as it would show that the close without merge was intentional.
>>
>> Another issue is that the build system looks like is in need of a bit of
>> love, some outdated and inconsistent dependencies for plugins. I fixed a
>> few, a few more that need a closer attentions. I saw that cshannon merged a
>> PR, I looked at it too, but I am not sure how it was tested as many test
>> fail intermittently, some just fail and jenkins didn't have a clean build
>> in a while. I'll look into those too.
>>
>> Cheers,
>> Hadrian
>>
>>
>> On 10/23/2016 02:11 AM, Jean-Baptiste Onofré wrote:
>>
>>> Good idea Hadrian.
>>>
>>> I will try to take a look.
>>>
>>> Regards
>>> JB
>>>
>>>
>>>
>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com>
>>> wrote:
>>>
>>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>>> are not relevant anymore. It'd be great if somebody could look into
>>>> them
>>>> and close them down. I will try to find some time next week and help
>>>> with that as well.
>>>>
>>>> Cheers,
>>>> Hadrian
>>>>
>>>> [1] https://github.com/apache/activemq/pulls
>>>>
>>>
>>>
>
Re: Many old open PRs
Posted by Christopher Shannon <ch...@gmail.com>.
Having a couple of build failures is not a problem when Jenkins runs
because it is configured to run through all tests regardless of any
failures. So while there are a handful of broken tests at any given time,
the other 8 or 9 thousand tests still run consistently. There is currently
one real OSGi failure right now but most of the failures are just tests
that need to be fixed because they are intermittently failing. Also, the
PR I merged was a new JNDI related class that had its own test. No where
else was that class instantiated so no other test would fail anyways.
On Mon, Oct 31, 2016 at 9:12 PM, Hadrian Zbarcea <hz...@gmail.com> wrote:
> Started to look into old PRs, some should not be merged. I'll see if I
> could sort it out with infra to get them closed without a commit, although
> imho, a commit like "This closes #xxx. Intentionally not merged" is better,
> as it would show that the close without merge was intentional.
>
> Another issue is that the build system looks like is in need of a bit of
> love, some outdated and inconsistent dependencies for plugins. I fixed a
> few, a few more that need a closer attentions. I saw that cshannon merged a
> PR, I looked at it too, but I am not sure how it was tested as many test
> fail intermittently, some just fail and jenkins didn't have a clean build
> in a while. I'll look into those too.
>
> Cheers,
> Hadrian
>
>
> On 10/23/2016 02:11 AM, Jean-Baptiste Onofré wrote:
>
>> Good idea Hadrian.
>>
>> I will try to take a look.
>>
>> Regards
>> JB
>>
>>
>>
>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com>
>> wrote:
>>
>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>> are not relevant anymore. It'd be great if somebody could look into
>>> them
>>> and close them down. I will try to find some time next week and help
>>> with that as well.
>>>
>>> Cheers,
>>> Hadrian
>>>
>>> [1] https://github.com/apache/activemq/pulls
>>>
>>
>>
Re: Many old open PRs
Posted by Hadrian Zbarcea <hz...@gmail.com>.
Started to look into old PRs, some should not be merged. I'll see if I
could sort it out with infra to get them closed without a commit,
although imho, a commit like "This closes #xxx. Intentionally not
merged" is better, as it would show that the close without merge was
intentional.
Another issue is that the build system looks like is in need of a bit of
love, some outdated and inconsistent dependencies for plugins. I fixed a
few, a few more that need a closer attentions. I saw that cshannon
merged a PR, I looked at it too, but I am not sure how it was tested as
many test fail intermittently, some just fail and jenkins didn't have a
clean build in a while. I'll look into those too.
Cheers,
Hadrian
On 10/23/2016 02:11 AM, Jean-Baptiste Onofr� wrote:
> Good idea Hadrian.
>
> I will try to take a look.
>
> Regards
> JB
>
> \u2063\u200b
>
> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com> wrote:
>> There are a number of old, even very old, PRs open [1]. Some I suspect
>> are not relevant anymore. It'd be great if somebody could look into
>> them
>> and close them down. I will try to find some time next week and help
>> with that as well.
>>
>> Cheers,
>> Hadrian
>>
>> [1] https://github.com/apache/activemq/pulls
>
Re: Many old open PRs
Posted by Hadrian Zbarcea <hz...@gmail.com>.
Follow instructions at:
http://apache.org/foundation/mailinglists.html
Cheers,
Hadrian
On 11/01/2016 09:40 PM, Renumathy B (NCS) wrote:
> Hello,
>
> I want to stop mails coming from this email address. Please help me to stop it.
>
> Thank you
>
> -----Original Message-----
> From: John D. Ament [mailto:johndament@apache.org]
> Sent: Wednesday, 2 November, 2016 06:50 AM
> To: dev@activemq.apache.org
> Subject: Re: Many old open PRs
>
> +1 as well, assuming you've pinged the ticket saying to fix or we won't
> +fix
> because..
>
> Better to group them together as well into a single commit, or as few commits as possible.
>
> BTW, I figured out what I did (since I couldn't find the commits with the message in them). Way back, we could force push on all branches, there were no protected branches unlike today. So what I did was commit, push, then squash the commits together into a functional commit and push -f that.
>
> John
>
> On Tue, Nov 1, 2016 at 6:06 PM Clebert Suconic <cl...@gmail.com>
> wrote:
>
>> +1...
>>
>>
>> But always try to ask the author to close it first (or fix it)... Just
>> out of politeness.
>>
>> Of course I don't mean this to the current batch of PRs.. there are
>> too many now and it would be difficult to do this for all of them..
>> just for a future workflow.
>>
>>
>>
>> On Tue, Nov 1, 2016 at 4:02 PM, Hadrian Zbarcea <hz...@gmail.com>
>> wrote:
>>> I had a quick chat with infra. The only two options to close a PR
>>> are
>> "This
>>> closes #..." or open a ticket. I doubt a new option will be
>>> available anytime soon. Opening a ticket sounds a bit overkill to me.
>>>
>>> I am ok with empty "This closes #..." on master or other branch,
>>> kind of neutral actually, I don't think it matters that much, even master is ok.
>> Any
>>> strong opinions?
>>>
>>> I would recommend a comment like: "This closes #xxx. Won't fix".
>>>
>>> Cheers,
>>> Hadrian
>>>
>>>
>>>
>>> On 10/24/2016 10:39 AM, Christopher Shannon wrote:
>>>>
>>>> I don't really like the idea of empty commits laying around. It
>>>> would
>> be
>>>> nice if infra could give us permission somehow to actually close
>>>> these commits on github.
>>>>
>>>> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic
>>>> <cl...@gmail.com>
>>>> wrote:
>>>>
>>>>> Yeah... that's what I meant by the "This closes #..."
>>>>>
>>>>> but if you are rejecting a PR, you will need the empty commit
>>>>> living in a branch.
>>>>>
>>>>>
>>>>> If we are ok with that, we can just add the empty commit.
>>>>>
>>>>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofr� <
>> jb@nanthrax.net>
>>>>> wrote:
>>>>>>
>>>>>> You can also create a "fake" commit containing "This closes #...".
>>>>>>
>>>>>> No need to request infra imho.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>> \u2063
>>>>>>
>>>>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
>>>>>
>>>>> clebert.suconic@gmail.com> wrote:
>>>>>>>
>>>>>>> There are ways to close a PR on Apache mirrors:
>>>>>>>
>>>>>>> - by merging the PR
>>>>>>> - by adding a commit saying.
>>>>>>> "This closes #NR"
>>>>>>> - by asking infra
>>>>>>>
>>>>>>>
>>>>>>> If the PR is stale you will need to ask infra. As no one outside
>>>>>>> the Apache infra have auth to close the PR.
>>>>>>>
>>>>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofr�
>>>>>>> <jb...@nanthrax.net>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Good idea Hadrian.
>>>>>>>>
>>>>>>>> I will try to take a look.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>> \u2063
>>>>>>>>
>>>>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <
>> hzbarcea@gmail.com
>>>>>>>> <javascript:;>> wrote:
>>>>>>>>>
>>>>>>>>> There are a number of old, even very old, PRs open [1]. Some I
>>>>>>>
>>>>>>> suspect
>>>>>>>>>
>>>>>>>>> are not relevant anymore. It'd be great if somebody could look
>>>>>>>>> into them and close them down. I will try to find some time
>>>>>>>>> next week and
>> help
>>>>>>>>> with that as well.
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>> Hadrian
>>>>>>>>>
>>>>>>>>> [1] https://github.com/apache/activemq/pulls
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Clebert Suconic
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Clebert Suconic
>>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Clebert Suconic
>>
RE: Many old open PRs
Posted by "Renumathy B (NCS)" <re...@ncs.com.sg>.
Hello,
I want to stop mails coming from this email address. Please help me to stop it.
Thank you
-----Original Message-----
From: John D. Ament [mailto:johndament@apache.org]
Sent: Wednesday, 2 November, 2016 06:50 AM
To: dev@activemq.apache.org
Subject: Re: Many old open PRs
+1 as well, assuming you've pinged the ticket saying to fix or we won't
+fix
because..
Better to group them together as well into a single commit, or as few commits as possible.
BTW, I figured out what I did (since I couldn't find the commits with the message in them). Way back, we could force push on all branches, there were no protected branches unlike today. So what I did was commit, push, then squash the commits together into a functional commit and push -f that.
John
On Tue, Nov 1, 2016 at 6:06 PM Clebert Suconic <cl...@gmail.com>
wrote:
> +1...
>
>
> But always try to ask the author to close it first (or fix it)... Just
> out of politeness.
>
> Of course I don't mean this to the current batch of PRs.. there are
> too many now and it would be difficult to do this for all of them..
> just for a future workflow.
>
>
>
> On Tue, Nov 1, 2016 at 4:02 PM, Hadrian Zbarcea <hz...@gmail.com>
> wrote:
> > I had a quick chat with infra. The only two options to close a PR
> > are
> "This
> > closes #..." or open a ticket. I doubt a new option will be
> > available anytime soon. Opening a ticket sounds a bit overkill to me.
> >
> > I am ok with empty "This closes #..." on master or other branch,
> > kind of neutral actually, I don't think it matters that much, even master is ok.
> Any
> > strong opinions?
> >
> > I would recommend a comment like: "This closes #xxx. Won't fix".
> >
> > Cheers,
> > Hadrian
> >
> >
> >
> > On 10/24/2016 10:39 AM, Christopher Shannon wrote:
> >>
> >> I don't really like the idea of empty commits laying around. It
> >> would
> be
> >> nice if infra could give us permission somehow to actually close
> >> these commits on github.
> >>
> >> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic
> >> <cl...@gmail.com>
> >> wrote:
> >>
> >>> Yeah... that's what I meant by the "This closes #..."
> >>>
> >>> but if you are rejecting a PR, you will need the empty commit
> >>> living in a branch.
> >>>
> >>>
> >>> If we are ok with that, we can just add the empty commit.
> >>>
> >>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <
> jb@nanthrax.net>
> >>> wrote:
> >>>>
> >>>> You can also create a "fake" commit containing "This closes #...".
> >>>>
> >>>> No need to request infra imho.
> >>>>
> >>>> Regards
> >>>> JB
> >>>>
> >>>>
> >>>>
> >>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
> >>>
> >>> clebert.suconic@gmail.com> wrote:
> >>>>>
> >>>>> There are ways to close a PR on Apache mirrors:
> >>>>>
> >>>>> - by merging the PR
> >>>>> - by adding a commit saying.
> >>>>> "This closes #NR"
> >>>>> - by asking infra
> >>>>>
> >>>>>
> >>>>> If the PR is stale you will need to ask infra. As no one outside
> >>>>> the Apache infra have auth to close the PR.
> >>>>>
> >>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofré
> >>>>> <jb...@nanthrax.net>
> >>>>> wrote:
> >>>>>
> >>>>>> Good idea Hadrian.
> >>>>>>
> >>>>>> I will try to take a look.
> >>>>>>
> >>>>>> Regards
> >>>>>> JB
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <
> hzbarcea@gmail.com
> >>>>>> <javascript:;>> wrote:
> >>>>>>>
> >>>>>>> There are a number of old, even very old, PRs open [1]. Some I
> >>>>>
> >>>>> suspect
> >>>>>>>
> >>>>>>> are not relevant anymore. It'd be great if somebody could look
> >>>>>>> into them and close them down. I will try to find some time
> >>>>>>> next week and
> help
> >>>>>>> with that as well.
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>> Hadrian
> >>>>>>>
> >>>>>>> [1] https://github.com/apache/activemq/pulls
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Clebert Suconic
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> Clebert Suconic
> >>>
> >>
> >
>
>
>
> --
> Clebert Suconic
>
Re: Many old open PRs
Posted by "John D. Ament" <jo...@apache.org>.
+1 as well, assuming you've pinged the ticket saying to fix or we won't fix
because..
Better to group them together as well into a single commit, or as few
commits as possible.
BTW, I figured out what I did (since I couldn't find the commits with the
message in them). Way back, we could force push on all branches, there
were no protected branches unlike today. So what I did was commit, push,
then squash the commits together into a functional commit and push -f that.
John
On Tue, Nov 1, 2016 at 6:06 PM Clebert Suconic <cl...@gmail.com>
wrote:
> +1...
>
>
> But always try to ask the author to close it first (or fix it)... Just
> out of politeness.
>
> Of course I don't mean this to the current batch of PRs.. there are
> too many now and it would be difficult to do this for all of them..
> just for a future workflow.
>
>
>
> On Tue, Nov 1, 2016 at 4:02 PM, Hadrian Zbarcea <hz...@gmail.com>
> wrote:
> > I had a quick chat with infra. The only two options to close a PR are
> "This
> > closes #..." or open a ticket. I doubt a new option will be available
> > anytime soon. Opening a ticket sounds a bit overkill to me.
> >
> > I am ok with empty "This closes #..." on master or other branch, kind of
> > neutral actually, I don't think it matters that much, even master is ok.
> Any
> > strong opinions?
> >
> > I would recommend a comment like: "This closes #xxx. Won't fix".
> >
> > Cheers,
> > Hadrian
> >
> >
> >
> > On 10/24/2016 10:39 AM, Christopher Shannon wrote:
> >>
> >> I don't really like the idea of empty commits laying around. It would
> be
> >> nice if infra could give us permission somehow to actually close these
> >> commits on github.
> >>
> >> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic
> >> <cl...@gmail.com>
> >> wrote:
> >>
> >>> Yeah... that's what I meant by the "This closes #..."
> >>>
> >>> but if you are rejecting a PR, you will need the empty commit living
> >>> in a branch.
> >>>
> >>>
> >>> If we are ok with that, we can just add the empty commit.
> >>>
> >>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <
> jb@nanthrax.net>
> >>> wrote:
> >>>>
> >>>> You can also create a "fake" commit containing "This closes #...".
> >>>>
> >>>> No need to request infra imho.
> >>>>
> >>>> Regards
> >>>> JB
> >>>>
> >>>>
> >>>>
> >>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
> >>>
> >>> clebert.suconic@gmail.com> wrote:
> >>>>>
> >>>>> There are ways to close a PR on Apache mirrors:
> >>>>>
> >>>>> - by merging the PR
> >>>>> - by adding a commit saying.
> >>>>> "This closes #NR"
> >>>>> - by asking infra
> >>>>>
> >>>>>
> >>>>> If the PR is stale you will need to ask infra. As no one outside the
> >>>>> Apache
> >>>>> infra have auth to close the PR.
> >>>>>
> >>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb...@nanthrax.net>
> >>>>> wrote:
> >>>>>
> >>>>>> Good idea Hadrian.
> >>>>>>
> >>>>>> I will try to take a look.
> >>>>>>
> >>>>>> Regards
> >>>>>> JB
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <
> hzbarcea@gmail.com
> >>>>>> <javascript:;>> wrote:
> >>>>>>>
> >>>>>>> There are a number of old, even very old, PRs open [1]. Some I
> >>>>>
> >>>>> suspect
> >>>>>>>
> >>>>>>> are not relevant anymore. It'd be great if somebody could look into
> >>>>>>> them
> >>>>>>> and close them down. I will try to find some time next week and
> help
> >>>>>>> with that as well.
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>> Hadrian
> >>>>>>>
> >>>>>>> [1] https://github.com/apache/activemq/pulls
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Clebert Suconic
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> Clebert Suconic
> >>>
> >>
> >
>
>
>
> --
> Clebert Suconic
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
+1...
But always try to ask the author to close it first (or fix it)... Just
out of politeness.
Of course I don't mean this to the current batch of PRs.. there are
too many now and it would be difficult to do this for all of them..
just for a future workflow.
On Tue, Nov 1, 2016 at 4:02 PM, Hadrian Zbarcea <hz...@gmail.com> wrote:
> I had a quick chat with infra. The only two options to close a PR are "This
> closes #..." or open a ticket. I doubt a new option will be available
> anytime soon. Opening a ticket sounds a bit overkill to me.
>
> I am ok with empty "This closes #..." on master or other branch, kind of
> neutral actually, I don't think it matters that much, even master is ok. Any
> strong opinions?
>
> I would recommend a comment like: "This closes #xxx. Won't fix".
>
> Cheers,
> Hadrian
>
>
>
> On 10/24/2016 10:39 AM, Christopher Shannon wrote:
>>
>> I don't really like the idea of empty commits laying around. It would be
>> nice if infra could give us permission somehow to actually close these
>> commits on github.
>>
>> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic
>> <cl...@gmail.com>
>> wrote:
>>
>>> Yeah... that's what I meant by the "This closes #..."
>>>
>>> but if you are rejecting a PR, you will need the empty commit living
>>> in a branch.
>>>
>>>
>>> If we are ok with that, we can just add the empty commit.
>>>
>>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
>>> wrote:
>>>>
>>>> You can also create a "fake" commit containing "This closes #...".
>>>>
>>>> No need to request infra imho.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>>
>>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
>>>
>>> clebert.suconic@gmail.com> wrote:
>>>>>
>>>>> There are ways to close a PR on Apache mirrors:
>>>>>
>>>>> - by merging the PR
>>>>> - by adding a commit saying.
>>>>> "This closes #NR"
>>>>> - by asking infra
>>>>>
>>>>>
>>>>> If the PR is stale you will need to ask infra. As no one outside the
>>>>> Apache
>>>>> infra have auth to close the PR.
>>>>>
>>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb...@nanthrax.net>
>>>>> wrote:
>>>>>
>>>>>> Good idea Hadrian.
>>>>>>
>>>>>> I will try to take a look.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
>>>>>> <javascript:;>> wrote:
>>>>>>>
>>>>>>> There are a number of old, even very old, PRs open [1]. Some I
>>>>>
>>>>> suspect
>>>>>>>
>>>>>>> are not relevant anymore. It'd be great if somebody could look into
>>>>>>> them
>>>>>>> and close them down. I will try to find some time next week and help
>>>>>>> with that as well.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Hadrian
>>>>>>>
>>>>>>> [1] https://github.com/apache/activemq/pulls
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Clebert Suconic
>>>
>>>
>>>
>>>
>>> --
>>> Clebert Suconic
>>>
>>
>
--
Clebert Suconic
Re: Many old open PRs
Posted by Hadrian Zbarcea <hz...@gmail.com>.
I had a quick chat with infra. The only two options to close a PR are
"This closes #..." or open a ticket. I doubt a new option will be
available anytime soon. Opening a ticket sounds a bit overkill to me.
I am ok with empty "This closes #..." on master or other branch, kind of
neutral actually, I don't think it matters that much, even master is ok.
Any strong opinions?
I would recommend a comment like: "This closes #xxx. Won't fix".
Cheers,
Hadrian
On 10/24/2016 10:39 AM, Christopher Shannon wrote:
> I don't really like the idea of empty commits laying around. It would be
> nice if infra could give us permission somehow to actually close these
> commits on github.
>
> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic <cl...@gmail.com>
> wrote:
>
>> Yeah... that's what I meant by the "This closes #..."
>>
>> but if you are rejecting a PR, you will need the empty commit living
>> in a branch.
>>
>>
>> If we are ok with that, we can just add the empty commit.
>>
>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofr� <jb...@nanthrax.net>
>> wrote:
>>> You can also create a "fake" commit containing "This closes #...".
>>>
>>> No need to request infra imho.
>>>
>>> Regards
>>> JB
>>>
>>> \u2063
>>>
>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
>> clebert.suconic@gmail.com> wrote:
>>>> There are ways to close a PR on Apache mirrors:
>>>>
>>>> - by merging the PR
>>>> - by adding a commit saying.
>>>> "This closes #NR"
>>>> - by asking infra
>>>>
>>>>
>>>> If the PR is stale you will need to ask infra. As no one outside the
>>>> Apache
>>>> infra have auth to close the PR.
>>>>
>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofr� <jb...@nanthrax.net>
>>>> wrote:
>>>>
>>>>> Good idea Hadrian.
>>>>>
>>>>> I will try to take a look.
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>> \u2063
>>>>>
>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
>>>>> <javascript:;>> wrote:
>>>>>> There are a number of old, even very old, PRs open [1]. Some I
>>>> suspect
>>>>>> are not relevant anymore. It'd be great if somebody could look into
>>>>>> them
>>>>>> and close them down. I will try to find some time next week and help
>>>>>> with that as well.
>>>>>>
>>>>>> Cheers,
>>>>>> Hadrian
>>>>>>
>>>>>> [1] https://github.com/apache/activemq/pulls
>>>>>
>>>>
>>>>
>>>> --
>>>> Clebert Suconic
>>
>>
>>
>> --
>> Clebert Suconic
>>
>
Re: Many old open PRs
Posted by "John D. Ament" <jo...@apache.org>.
Interesting, that used to work at least. I wonder if github has changed
something recently.
John
On Fri, Oct 28, 2016 at 4:46 PM Clebert Suconic <cl...@gmail.com>
wrote:
> https://github.com/apache/activemq-artemis/pull/873
>
> ^^ didn't work
>
> On Fri, Oct 28, 2016 at 4:46 PM, Clebert Suconic
> <cl...@gmail.com> wrote:
> > I just tried the tmp branch approach and it didn't work:
> >
> > I guess it must be on master, otherwise the apache bot won't see it.
> > Unless we ask Infra to tweak the bot.
> >
> > On Tue, Oct 25, 2016 at 6:22 AM, Christopher Shannon
> > <ch...@gmail.com> wrote:
> >> +1 for using a temporary branch and then deleting it after the PR is
> >> closed. That way there's no empty commits laying around.
> >>
> >> On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconic <
> clebert.suconic@gmail.com>
> >> wrote:
> >>
> >>> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org>
> >>> wrote:
> >>> > You can also push up the commits to a separate branch, which closes
> the
> >>> PR,
> >>> > then delete that branch (note you have to eventually push a real
> commit
> >>> on
> >>> > top so there will be a short delay until someone commits to git in a
> >>> > non-delete fashion).
> >>> >
> >>>
> >>> Ahhhhh.... a temporary branch... hmmmm
> >>>
> >>> We can push -f :temporary-branch when it's closed.
> >>>
> >>>
> >>> That works
> >>>
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
https://github.com/apache/activemq-artemis/pull/873
^^ didn't work
On Fri, Oct 28, 2016 at 4:46 PM, Clebert Suconic
<cl...@gmail.com> wrote:
> I just tried the tmp branch approach and it didn't work:
>
> I guess it must be on master, otherwise the apache bot won't see it.
> Unless we ask Infra to tweak the bot.
>
> On Tue, Oct 25, 2016 at 6:22 AM, Christopher Shannon
> <ch...@gmail.com> wrote:
>> +1 for using a temporary branch and then deleting it after the PR is
>> closed. That way there's no empty commits laying around.
>>
>> On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconic <cl...@gmail.com>
>> wrote:
>>
>>> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org>
>>> wrote:
>>> > You can also push up the commits to a separate branch, which closes the
>>> PR,
>>> > then delete that branch (note you have to eventually push a real commit
>>> on
>>> > top so there will be a short delay until someone commits to git in a
>>> > non-delete fashion).
>>> >
>>>
>>> Ahhhhh.... a temporary branch... hmmmm
>>>
>>> We can push -f :temporary-branch when it's closed.
>>>
>>>
>>> That works
>>>
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
I just tried the tmp branch approach and it didn't work:
I guess it must be on master, otherwise the apache bot won't see it.
Unless we ask Infra to tweak the bot.
On Tue, Oct 25, 2016 at 6:22 AM, Christopher Shannon
<ch...@gmail.com> wrote:
> +1 for using a temporary branch and then deleting it after the PR is
> closed. That way there's no empty commits laying around.
>
> On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconic <cl...@gmail.com>
> wrote:
>
>> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org>
>> wrote:
>> > You can also push up the commits to a separate branch, which closes the
>> PR,
>> > then delete that branch (note you have to eventually push a real commit
>> on
>> > top so there will be a short delay until someone commits to git in a
>> > non-delete fashion).
>> >
>>
>> Ahhhhh.... a temporary branch... hmmmm
>>
>> We can push -f :temporary-branch when it's closed.
>>
>>
>> That works
>>
--
Clebert Suconic
Re: Many old open PRs
Posted by Christopher Shannon <ch...@gmail.com>.
+1 for using a temporary branch and then deleting it after the PR is
closed. That way there's no empty commits laying around.
On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconic <cl...@gmail.com>
wrote:
> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org>
> wrote:
> > You can also push up the commits to a separate branch, which closes the
> PR,
> > then delete that branch (note you have to eventually push a real commit
> on
> > top so there will be a short delay until someone commits to git in a
> > non-delete fashion).
> >
>
> Ahhhhh.... a temporary branch... hmmmm
>
> We can push -f :temporary-branch when it's closed.
>
>
> That works
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org> wrote:
> You can also push up the commits to a separate branch, which closes the PR,
> then delete that branch (note you have to eventually push a real commit on
> top so there will be a short delay until someone commits to git in a
> non-delete fashion).
>
Ahhhhh.... a temporary branch... hmmmm
We can push -f :temporary-branch when it's closed.
That works
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
On Mon, Oct 24, 2016 at 4:55 PM, John D. Ament <jo...@apache.org> wrote:
> On Mon, Oct 24, 2016 at 4:33 PM Clebert Suconic <cl...@gmail.com>
> wrote:
>
>> I thought about that, create a fake branch for fake commits...
>>
>> I just didn't like it, that's why i didn't suggest it.
>
> Curious as to why. The permanent record's in the email threads.
Let me rephrase it.
In order of preference:
I - to be able to close the PR with a close button. (not possible
probably), but it would be the best option.
II - open a fake branch (name it rejected-PRs or whatever you like,
the name is not important now), and commit empty commits on it.
III - the empty commit on master. (I don't like it for aesthetics
reasons.. probably my OCD).
IV - call infra guys. (I would rather not do it since they are already
busy with other things)
> And yes, I suspect this is more of an activemq classic issue, since it
> seems to be a target of drive by "let me increase my pull request count"
I would just say we have a good workflow around Pull requests :)
Re: Many old open PRs
Posted by "John D. Ament" <jo...@apache.org>.
On Mon, Oct 24, 2016 at 4:33 PM Clebert Suconic <cl...@gmail.com>
wrote:
> I thought about that, create a fake branch for fake commits...
>
> I just didn't like it, that's why i didn't suggest it.
>
Curious as to why. The permanent record's in the email threads.
And yes, I suspect this is more of an activemq classic issue, since it
seems to be a target of drive by "let me increase my pull request count"
>
>
> On Artemis we usually get a good response on PRs... there was just one
> exception that the guy never came back and I used the empty commit
> here:
>
>
> https://github.com/apache/activemq-artemis/commit/224770168bdf1b255eff2fac2464d08fa674b3cc
>
>
> The good thing is that we have it registered (why the commit was not
> merged). but if you have too many PRs, it would get annoying.
>
> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org>
> wrote:
> > You can also push up the commits to a separate branch, which closes the
> PR,
> > then delete that branch (note you have to eventually push a real commit
> on
> > top so there will be a short delay until someone commits to git in a
> > non-delete fashion).
> >
> > John
> >
> > On Mon, Oct 24, 2016 at 4:25 PM Clebert Suconic <
> clebert.suconic@gmail.com>
> > wrote:
> >
> >> On Mon, Oct 24, 2016 at 10:39 AM, Christopher Shannon
> >> <ch...@gmail.com> wrote:
> >> > I don't really like the idea of empty commits laying around. It
> would be
> >> > nice if infra could give us permission somehow to actually close these
> >> > commits on github.
> >>
> >> +1
> >>
> >> although I can see why Infra is doing that.
> >>
> >> there's a fork update through the apache bot (the github fork is in
> >> sync with the apache git), and if someone pushes the "merge" button on
> >> github by accident, a lot of stuff would probably be broken?
> >>
> >> There's no way (afaik) to only permit closing a PR. You would get all
> >> or nothing.
> >>
> >>
> >> But if we could have at least one person on our group with that power.
> >> (Bruce maybe?) we would speed up the process IMO.
> >>
>
>
>
> --
> Clebert Suconic
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
I thought about that, create a fake branch for fake commits...
I just didn't like it, that's why i didn't suggest it.
On Artemis we usually get a good response on PRs... there was just one
exception that the guy never came back and I used the empty commit
here:
https://github.com/apache/activemq-artemis/commit/224770168bdf1b255eff2fac2464d08fa674b3cc
The good thing is that we have it registered (why the commit was not
merged). but if you have too many PRs, it would get annoying.
On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <jo...@apache.org> wrote:
> You can also push up the commits to a separate branch, which closes the PR,
> then delete that branch (note you have to eventually push a real commit on
> top so there will be a short delay until someone commits to git in a
> non-delete fashion).
>
> John
>
> On Mon, Oct 24, 2016 at 4:25 PM Clebert Suconic <cl...@gmail.com>
> wrote:
>
>> On Mon, Oct 24, 2016 at 10:39 AM, Christopher Shannon
>> <ch...@gmail.com> wrote:
>> > I don't really like the idea of empty commits laying around. It would be
>> > nice if infra could give us permission somehow to actually close these
>> > commits on github.
>>
>> +1
>>
>> although I can see why Infra is doing that.
>>
>> there's a fork update through the apache bot (the github fork is in
>> sync with the apache git), and if someone pushes the "merge" button on
>> github by accident, a lot of stuff would probably be broken?
>>
>> There's no way (afaik) to only permit closing a PR. You would get all
>> or nothing.
>>
>>
>> But if we could have at least one person on our group with that power.
>> (Bruce maybe?) we would speed up the process IMO.
>>
--
Clebert Suconic
Re: Many old open PRs
Posted by "John D. Ament" <jo...@apache.org>.
You can also push up the commits to a separate branch, which closes the PR,
then delete that branch (note you have to eventually push a real commit on
top so there will be a short delay until someone commits to git in a
non-delete fashion).
John
On Mon, Oct 24, 2016 at 4:25 PM Clebert Suconic <cl...@gmail.com>
wrote:
> On Mon, Oct 24, 2016 at 10:39 AM, Christopher Shannon
> <ch...@gmail.com> wrote:
> > I don't really like the idea of empty commits laying around. It would be
> > nice if infra could give us permission somehow to actually close these
> > commits on github.
>
> +1
>
> although I can see why Infra is doing that.
>
> there's a fork update through the apache bot (the github fork is in
> sync with the apache git), and if someone pushes the "merge" button on
> github by accident, a lot of stuff would probably be broken?
>
> There's no way (afaik) to only permit closing a PR. You would get all
> or nothing.
>
>
> But if we could have at least one person on our group with that power.
> (Bruce maybe?) we would speed up the process IMO.
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
On Mon, Oct 24, 2016 at 10:39 AM, Christopher Shannon
<ch...@gmail.com> wrote:
> I don't really like the idea of empty commits laying around. It would be
> nice if infra could give us permission somehow to actually close these
> commits on github.
+1
although I can see why Infra is doing that.
there's a fork update through the apache bot (the github fork is in
sync with the apache git), and if someone pushes the "merge" button on
github by accident, a lot of stuff would probably be broken?
There's no way (afaik) to only permit closing a PR. You would get all
or nothing.
But if we could have at least one person on our group with that power.
(Bruce maybe?) we would speed up the process IMO.
Re: Many old open PRs
Posted by Christopher Shannon <ch...@gmail.com>.
I don't really like the idea of empty commits laying around. It would be
nice if infra could give us permission somehow to actually close these
commits on github.
On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic <cl...@gmail.com>
wrote:
> Yeah... that's what I meant by the "This closes #..."
>
> but if you are rejecting a PR, you will need the empty commit living
> in a branch.
>
>
> If we are ok with that, we can just add the empty commit.
>
> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
> > You can also create a "fake" commit containing "This closes #...".
> >
> > No need to request infra imho.
> >
> > Regards
> > JB
> >
> >
> >
> > On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
> clebert.suconic@gmail.com> wrote:
> >>There are ways to close a PR on Apache mirrors:
> >>
> >>- by merging the PR
> >>- by adding a commit saying.
> >> "This closes #NR"
> >>- by asking infra
> >>
> >>
> >>If the PR is stale you will need to ask infra. As no one outside the
> >>Apache
> >>infra have auth to close the PR.
> >>
> >>On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb...@nanthrax.net>
> >>wrote:
> >>
> >>> Good idea Hadrian.
> >>>
> >>> I will try to take a look.
> >>>
> >>> Regards
> >>> JB
> >>>
> >>>
> >>>
> >>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
> >>> <javascript:;>> wrote:
> >>> >There are a number of old, even very old, PRs open [1]. Some I
> >>suspect
> >>> >are not relevant anymore. It'd be great if somebody could look into
> >>> >them
> >>> >and close them down. I will try to find some time next week and help
> >>> >with that as well.
> >>> >
> >>> >Cheers,
> >>> >Hadrian
> >>> >
> >>> >[1] https://github.com/apache/activemq/pulls
> >>>
> >>
> >>
> >>--
> >>Clebert Suconic
>
>
>
> --
> Clebert Suconic
>
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
Yeah... that's what I meant by the "This closes #..."
but if you are rejecting a PR, you will need the empty commit living
in a branch.
If we are ok with that, we can just add the empty commit.
On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> You can also create a "fake" commit containing "This closes #...".
>
> No need to request infra imho.
>
> Regards
> JB
>
>
>
> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <cl...@gmail.com> wrote:
>>There are ways to close a PR on Apache mirrors:
>>
>>- by merging the PR
>>- by adding a commit saying.
>> "This closes #NR"
>>- by asking infra
>>
>>
>>If the PR is stale you will need to ask infra. As no one outside the
>>Apache
>>infra have auth to close the PR.
>>
>>On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb...@nanthrax.net>
>>wrote:
>>
>>> Good idea Hadrian.
>>>
>>> I will try to take a look.
>>>
>>> Regards
>>> JB
>>>
>>>
>>>
>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
>>> <javascript:;>> wrote:
>>> >There are a number of old, even very old, PRs open [1]. Some I
>>suspect
>>> >are not relevant anymore. It'd be great if somebody could look into
>>> >them
>>> >and close them down. I will try to find some time next week and help
>>> >with that as well.
>>> >
>>> >Cheers,
>>> >Hadrian
>>> >
>>> >[1] https://github.com/apache/activemq/pulls
>>>
>>
>>
>>--
>>Clebert Suconic
--
Clebert Suconic
Re: Many old open PRs
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
You can also create a "fake" commit containing "This closes #...".
No need to request infra imho.
Regards
JB
\u2063\u200b
On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <cl...@gmail.com> wrote:
>There are ways to close a PR on Apache mirrors:
>
>- by merging the PR
>- by adding a commit saying.
> "This closes #NR"
>- by asking infra
>
>
>If the PR is stale you will need to ask infra. As no one outside the
>Apache
>infra have auth to close the PR.
>
>On Sunday, October 23, 2016, Jean-Baptiste Onofr� <jb...@nanthrax.net>
>wrote:
>
>> Good idea Hadrian.
>>
>> I will try to take a look.
>>
>> Regards
>> JB
>>
>> \u2063\u200b
>>
>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
>> <javascript:;>> wrote:
>> >There are a number of old, even very old, PRs open [1]. Some I
>suspect
>> >are not relevant anymore. It'd be great if somebody could look into
>> >them
>> >and close them down. I will try to find some time next week and help
>> >with that as well.
>> >
>> >Cheers,
>> >Hadrian
>> >
>> >[1] https://github.com/apache/activemq/pulls
>>
>
>
>--
>Clebert Suconic
Re: Many old open PRs
Posted by Clebert Suconic <cl...@gmail.com>.
There are ways to close a PR on Apache mirrors:
- by merging the PR
- by adding a commit saying.
"This closes #NR"
- by asking infra
If the PR is stale you will need to ask infra. As no one outside the Apache
infra have auth to close the PR.
On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Good idea Hadrian.
>
> I will try to take a look.
>
> Regards
> JB
>
>
>
> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
> <javascript:;>> wrote:
> >There are a number of old, even very old, PRs open [1]. Some I suspect
> >are not relevant anymore. It'd be great if somebody could look into
> >them
> >and close them down. I will try to find some time next week and help
> >with that as well.
> >
> >Cheers,
> >Hadrian
> >
> >[1] https://github.com/apache/activemq/pulls
>
--
Clebert Suconic
Re: Many old open PRs
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Good idea Hadrian.
I will try to take a look.
Regards
JB
\u2063\u200b
On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hz...@gmail.com> wrote:
>There are a number of old, even very old, PRs open [1]. Some I suspect
>are not relevant anymore. It'd be great if somebody could look into
>them
>and close them down. I will try to find some time next week and help
>with that as well.
>
>Cheers,
>Hadrian
>
>[1] https://github.com/apache/activemq/pulls