You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/05 09:13:23 UTC
[GitHub] [camel-kafka-connector] apupier opened a new issue #671: Provide validation of properties file from the catalog
apupier opened a new issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671
The Camel core catalog is providing a validation mechanism. For instance, by checking that parameters used are valid. This validation is used by camel maven plugin and by Camel Language Server.
It would be interesting to provide validation too for properties file.
- [ ] Provide API method taking a properties string text and returning a list of Validation result. The validation result should contain at least a message and the range.
- [ ] Validate that property key is valid
- [ ] Validate that camel.(source|sink) corresponds to the source sink nature of the connector.class
- [ ] Validate that connector class and camel.(source|sink).url is valid
- [ ] Validate that required properties are available
- [ ] Validate that there is no duplicated keys (with the variation of dashed names and camelCase name)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671#issuecomment-722455305
I do think it makes sense to have it as part of Camel Language Server
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671#issuecomment-722358807
question: is it relevant to have it in Camel Kafka Connector project? given that the properties files seems to be usually standalone, not inside a Maven or Gradle project. Maybe this would be better to implement it only in Camel Language Server side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671#issuecomment-722478936
to provide range, it might be useful to reuse the PropertiesParser from Microprofile/Quarkus Language Server https://github.com/eclipse/lsp4mp/blob/master/microprofile.ls/org.eclipse.lsp4mp.ls/src/main/java/org/eclipse/lsp4mp/model/parser/PropertiesParser.java there are discussions to extract it https://coreos.slack.com/archives/CK14U2L4V/p1604591998095300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671#issuecomment-722454729
if part of Catalog, is it possible to reuse some LSP4J API for Range, or perhaps even org.eclipse.lsp4j.Diagnostic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier closed issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
apupier closed issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on issue #671: Provide validation of properties file from the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #671:
URL: https://github.com/apache/camel-kafka-connector/issues/671#issuecomment-739928193
> I do think it makes sense to have it as part of Camel Language Server
created Epic https://issues.redhat.com/browse/FUSETOOLS2-905 to provide the validation at Camel language Server only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org