[GitHub] iilyak opened a new pull request #1778: Cache query servers in ets table

[GitBox <gi...@apache.org>]

iilyak opened a new pull request #1778: Cache query servers in ets table
URL: https://github.com/apache/couchdb/pull/1778
 
 
   ## Overview
   
   The configuration of query servers is done via environment variables.
   Calling os:getenv every time we need a new query process is expensive.
   Instead we extact all configured query servers from the environemt on
   `couch_proc_manager` startup and cache them in ets table.
   
   fixes #1772
   
   ## Testing recommendations
   
   
   1. make eunit
   2. remsh into running dev cluster and check the following
    - `ets:tab2list(couch_proc_manager_servers).` - returns 
      - COFFEESCRIPT
      - QUERY
      - JAVASCRIPT
    - update config to enable native query server `config:set("native_query_servers", "enable_erlang_query_server", "true", false).`
     - make sure `ets:tab2list(couch_proc_manager_servers).` includes ERLANG
   
   ## Related Issues or Pull Requests
   
   - https://github.com/apache/couchdb/issues/1772
   - https://github.com/apache/couchdb/pull/1602
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services