You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:38:45 UTC

[GitHub] [iotdb] chengjianyun commented on pull request #3638: [IOTDB-1484]Auto create schema functionality with e2e testing in cluster

chengjianyun commented on pull request #3638:
URL: https://github.com/apache/iotdb/pull/3638#issuecomment-909053550


   Love the refine logic of error handling  in the PR very much. For auto creating schema, I have a suggestion. Is there any way that put the creation logic in executor instead of coordinator as I have done in https://github.com/apache/iotdb/pull/3770? 
   
   Executor takes charge of schema auto creation could reduce a RTT between coordinator and simplify the error handling process. When an exception is thrown to coordinator, then it must not be resolved by retry or something like. So coordinator only needs to properly sends the error to user and/or record some log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org