You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Emmanuel Lécharny <el...@gmail.com> on 2015/01/11 19:08:43 UTC
[kerby/haox] Dependencies updates needed
Hi,
I just check for the dependencies use by Kerby/Haox, there are a few
that require to be bumped up :
[INFO] Building Haox Project 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Third Party Projects 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building not-yet-commons-ssl 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] commons-httpclient:commons-httpclient ..................... 3.0
-> 3.1
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] log4j:log4j ......................................... 1.2.13 ->
1.2.17
[INFO] org.mockito:mockito-all .......................... 1.9.5 ->
2.0.2-beta
[INFO]
[INFO] Building Contrib Projects 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-config 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] org.slf4j:slf4j-api .................................. 1.7.5 ->
1.7.10
[INFO]
[INFO] Building Haox Event 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-asn1 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox PKIX 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-token Project 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] com.nimbusds:nimbus-jose-jwt .............................. 3.2
-> 3.5
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Project 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb core 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Crypto 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Util 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-kerb-coreTest 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Common 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Identity 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Client 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Server 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb-KdcTest 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kdc Project 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Ldap identity backend 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox KDC Server 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Tools 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox benchmark 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] org.apache.directory.api:api-all .............. 1.0.0-M20 ->
1.0.0-M27
[INFO] org.apache.directory.server:apacheds-core-api ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-interceptor-kerberos ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-ldif-partition ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-mavibot-partition ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-protocol-kerberos ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-protocol-shared ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
>> In any case, even if we keep the Java standard code format, there are things that must change for rational reasons ...
I agree with the points made below the point. Maybe we only require the main coding style to be consistent, I doubt if we're able to enforce the rules in details strictly unless we have such tool.
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Tuesday, January 13, 2015 5:17 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 13/01/15 09:30, Kiran Ayyagari a écrit :
> On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai <ka...@intel.com> wrote:
>
>>>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2
>> spaces.
>> Agree, let's follow this.
>>
>>>> Regarding teh Java code, I suggest we keep what you have (likely
>>>> Java
>> code convention), we can vote later on keep it or moving globally to
>> another convention.
>> I do like the current one that can be most easily setup in IDEA or
>> Eclipse in my view and is also very concise/compact in lines, but
>> sure I would follow the best practice if we vote one. The major
>> concern would be we have to find/write a tool to convert the existing
>> codes to use the new style if we have to change.
>>
>> Current codes follow in the following style I copied from IDEA template.
>> ===
>> public class Foo {
>> public int[] X = new int[]{1, 3, 5 7, 9, 11};
>>
>> public void foo(boolean a, int x, int y, int z) {
>> label1:
>> do {
>> try {
>> if (x > 0) {
>> int someVariable = a ? x : y;
>> int anotherVariable = a ? x : y;
>> } else if (x < 0) {
>> int someVariable = (y + z);
>> someVariable = x = x + y;
>> } else {
>> label2:
>> for (int i = 0; i < 5; i++) doSomething(i);
>>
> the above block certainly hurts my eyes ;)
I can understand. But let's not be religious about that...
In any case, even if we keep the Java standard code format, there are things that must change for rational reasons :
1) int someVariable = a ? x : y;
Barely readable. And it's just about using simple variables here, but when it comes to complex expressions, the ? and : will be totally invisible.
Better write :
if ( a ) {
int someVariable = x;
} else {
int someVariable = y;
}
Way more readable.
2) someVariable = x = x + y;
Yuk. Everytime I see such construct, I vomit. Again, this is an almost guarantee to fuck up big time. Every expression when a normal human being have to *think* to understand what the code is doing is a nail in the coffin of what computer science is made for : spare a human being the pain to think.
3) for (int i = 0; i < 5; i++) doSomething(i);
Any construction where a loop is done without { and } to enclose the expression to execute is dangerous.
At first, you do something like :
for (int i = 0; i < 5; i++);
then you decide to do something and change the code to be :
for (int i = 0; i < 5; i++);
doSomething(i);
Now, you are totally fuxked, and it may takes hour to understand why.
*Every* single expression must be enclosed into { and }.
Otherwise, I don't mind if we decide to use Java coding convention. I prefer the Directory coding convention, because I'm under no obligation to work on a VT-100 since 1985, so with my 1680x1050 display, with 50 lines/200 char per line screen (and it's a laptop, I'm not mentionning those who use a 30" screen here...), and even when using Monaco 11 fonts - and being 50 years old, with difficulties to read small font, it tells something ;-), I have no problem with spaced code.
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
>> besides all that said above, as a person who works on more than one sub-project of ApacheDS I wish to spare some pain for my eyes and fingers everyday while switching between source files in the editor.
For me I have separate workspace for project using different coding style with the style profile set in IDE, so I don’t have to switch. Even I need it’s pretty easy to switch between the style profiles.
I’m sorry about the inconvenience. It would be great if we could make it also easy and comfortable for new contributors. It’s critical for the new project not only because we need continuously more effort but also regarding developing of the community as Emmanuel told when considering to promote it as a TLP in future.
Regards,
Kai
From: Kiran Ayyagari [mailto:kayyagari@apache.org]
Sent: Tuesday, January 13, 2015 5:30 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
On Tue, Jan 13, 2015 at 5:17 PM, Emmanuel Lécharny <el...@gmail.com>> wrote:
Le 13/01/15 09:30, Kiran Ayyagari a écrit :
> On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai <ka...@intel.com>> wrote:
>
>>>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2
>> spaces.
>> Agree, let's follow this.
>>
>>>> Regarding teh Java code, I suggest we keep what you have (likely Java
>> code convention), we can vote later on keep it or moving globally to
>> another convention.
>> I do like the current one that can be most easily setup in IDEA or Eclipse
>> in my view and is also very concise/compact in lines, but sure I would
>> follow the best practice if we vote one. The major concern would be we have
>> to find/write a tool to convert the existing codes to use the new style if
>> we have to change.
>>
>> Current codes follow in the following style I copied from IDEA template.
>> ===
>> public class Foo {
>> public int[] X = new int[]{1, 3, 5 7, 9, 11};
>>
>> public void foo(boolean a, int x, int y, int z) {
>> label1:
>> do {
>> try {
>> if (x > 0) {
>> int someVariable = a ? x : y;
>> int anotherVariable = a ? x : y;
>> } else if (x < 0) {
>> int someVariable = (y + z);
>> someVariable = x = x + y;
>> } else {
>> label2:
>> for (int i = 0; i < 5; i++) doSomething(i);
>>
> the above block certainly hurts my eyes ;)
I can understand. But let's not be religious about that...
definitely not :)
In any case, even if we keep the Java standard code format, there are
things that must change for rational reasons :
1) int someVariable = a ? x : y;
Barely readable. And it's just about using simple variables here, but
when it comes to complex expressions, the ? and : will be totally invisible.
Better write :
if ( a ) {
int someVariable = x;
} else {
int someVariable = y;
}
Way more readable.
2) someVariable = x = x + y;
Yuk. Everytime I see such construct, I vomit. Again, this is an almost guarantee to fuck up big time. Every expression when a normal human being have to *think* to understand what the code is doing is a nail in the coffin of what computer science is made for : spare a human being the pain to think.
3) for (int i = 0; i < 5; i++) doSomething(i);
Any construction where a loop is done without { and } to enclose the expression to execute is dangerous.
At first, you do something like :
for (int i = 0; i < 5; i++);
then you decide to do something and change the code to be :
for (int i = 0; i < 5; i++);
doSomething(i);
Now, you are totally fuxked, and it may takes hour to understand why.
*Every* single expression must be enclosed into { and }.
besides all that said above, as a person who works on more than one sub-project of ApacheDS I wish to spare some
pain for my eyes and fingers everyday while switching between source files in the editor.
Otherwise, I don't mind if we decide to use Java coding convention. I prefer the Directory coding convention, because I'm under no obligation to work on a VT-100 since 1985, so with my 1680x1050 display, with 50 lines/200 char per line screen (and it's a laptop, I'm not mentionning those who use a 30" screen here...), and even when using Monaco 11 fonts - and being 50 years old, with difficulties to read small font, it tells something ;-), I have no problem with spaced code.
--
Kiran Ayyagari
http://keydap.com
Re: [kerby/haox] Dependencies updates needed
Posted by Kiran Ayyagari <ka...@apache.org>.
On Tue, Jan 13, 2015 at 5:17 PM, Emmanuel Lécharny <el...@gmail.com>
wrote:
> Le 13/01/15 09:30, Kiran Ayyagari a écrit :
> > On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai <ka...@intel.com> wrote:
> >
> >>>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2
> >> spaces.
> >> Agree, let's follow this.
> >>
> >>>> Regarding teh Java code, I suggest we keep what you have (likely Java
> >> code convention), we can vote later on keep it or moving globally to
> >> another convention.
> >> I do like the current one that can be most easily setup in IDEA or
> Eclipse
> >> in my view and is also very concise/compact in lines, but sure I would
> >> follow the best practice if we vote one. The major concern would be we
> have
> >> to find/write a tool to convert the existing codes to use the new style
> if
> >> we have to change.
> >>
> >> Current codes follow in the following style I copied from IDEA template.
> >> ===
> >> public class Foo {
> >> public int[] X = new int[]{1, 3, 5 7, 9, 11};
> >>
> >> public void foo(boolean a, int x, int y, int z) {
> >> label1:
> >> do {
> >> try {
> >> if (x > 0) {
> >> int someVariable = a ? x : y;
> >> int anotherVariable = a ? x : y;
> >> } else if (x < 0) {
> >> int someVariable = (y + z);
> >> someVariable = x = x + y;
> >> } else {
> >> label2:
> >> for (int i = 0; i < 5; i++) doSomething(i);
> >>
> > the above block certainly hurts my eyes ;)
>
>
> I can understand. But let's not be religious about that...
>
> definitely not :)
> In any case, even if we keep the Java standard code format, there are
> things that must change for rational reasons :
>
> 1) int someVariable = a ? x : y;
>
> Barely readable. And it's just about using simple variables here, but
> when it comes to complex expressions, the ? and : will be totally
> invisible.
>
> Better write :
>
> if ( a ) {
> int someVariable = x;
> } else {
> int someVariable = y;
> }
>
> Way more readable.
>
> 2) someVariable = x = x + y;
>
> Yuk. Everytime I see such construct, I vomit. Again, this is an almost
> guarantee to fuck up big time. Every expression when a normal human being
> have to *think* to understand what the code is doing is a nail in the
> coffin of what computer science is made for : spare a human being the pain
> to think.
>
> 3) for (int i = 0; i < 5; i++) doSomething(i);
>
> Any construction where a loop is done without { and } to enclose the
> expression to execute is dangerous.
>
> At first, you do something like :
>
> for (int i = 0; i < 5; i++);
>
> then you decide to do something and change the code to be :
>
> for (int i = 0; i < 5; i++);
> doSomething(i);
>
> Now, you are totally fuxked, and it may takes hour to understand why.
>
> *Every* single expression must be enclosed into { and }.
>
>
> besides all that said above, as a person who works on more than one
sub-project of ApacheDS I wish to spare some
pain for my eyes and fingers everyday while switching between source files
in the editor.
> Otherwise, I don't mind if we decide to use Java coding convention. I
> prefer the Directory coding convention, because I'm under no obligation to
> work on a VT-100 since 1985, so with my 1680x1050 display, with 50
> lines/200 char per line screen (and it's a laptop, I'm not mentionning
> those who use a 30" screen here...), and even when using Monaco 11 fonts -
> and being 50 years old, with difficulties to read small font, it tells
> something ;-), I have no problem with spaced code.
>
>
>
>
--
Kiran Ayyagari
http://keydap.com
Re: [kerby/haox] Dependencies updates needed
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 13/01/15 09:30, Kiran Ayyagari a écrit :
> On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai <ka...@intel.com> wrote:
>
>>>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2
>> spaces.
>> Agree, let's follow this.
>>
>>>> Regarding teh Java code, I suggest we keep what you have (likely Java
>> code convention), we can vote later on keep it or moving globally to
>> another convention.
>> I do like the current one that can be most easily setup in IDEA or Eclipse
>> in my view and is also very concise/compact in lines, but sure I would
>> follow the best practice if we vote one. The major concern would be we have
>> to find/write a tool to convert the existing codes to use the new style if
>> we have to change.
>>
>> Current codes follow in the following style I copied from IDEA template.
>> ===
>> public class Foo {
>> public int[] X = new int[]{1, 3, 5 7, 9, 11};
>>
>> public void foo(boolean a, int x, int y, int z) {
>> label1:
>> do {
>> try {
>> if (x > 0) {
>> int someVariable = a ? x : y;
>> int anotherVariable = a ? x : y;
>> } else if (x < 0) {
>> int someVariable = (y + z);
>> someVariable = x = x + y;
>> } else {
>> label2:
>> for (int i = 0; i < 5; i++) doSomething(i);
>>
> the above block certainly hurts my eyes ;)
I can understand. But let's not be religious about that...
In any case, even if we keep the Java standard code format, there are
things that must change for rational reasons :
1) int someVariable = a ? x : y;
Barely readable. And it's just about using simple variables here, but
when it comes to complex expressions, the ? and : will be totally invisible.
Better write :
if ( a ) {
int someVariable = x;
} else {
int someVariable = y;
}
Way more readable.
2) someVariable = x = x + y;
Yuk. Everytime I see such construct, I vomit. Again, this is an almost guarantee to fuck up big time. Every expression when a normal human being have to *think* to understand what the code is doing is a nail in the coffin of what computer science is made for : spare a human being the pain to think.
3) for (int i = 0; i < 5; i++) doSomething(i);
Any construction where a loop is done without { and } to enclose the expression to execute is dangerous.
At first, you do something like :
for (int i = 0; i < 5; i++);
then you decide to do something and change the code to be :
for (int i = 0; i < 5; i++);
doSomething(i);
Now, you are totally fuxked, and it may takes hour to understand why.
*Every* single expression must be enclosed into { and }.
Otherwise, I don't mind if we decide to use Java coding convention. I prefer the Directory coding convention, because I'm under no obligation to work on a VT-100 since 1985, so with my 1680x1050 display, with 50 lines/200 char per line screen (and it's a laptop, I'm not mentionning those who use a 30" screen here...), and even when using Monaco 11 fonts - and being 50 years old, with difficulties to read small font, it tells something ;-), I have no problem with spaced code.
Re: [kerby/haox] Dependencies updates needed
Posted by Kiran Ayyagari <ka...@apache.org>.
On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai <ka...@intel.com> wrote:
> >> I don't like 4 spaces for XML files, it's quickly too wide, I use 2
> spaces.
> Agree, let's follow this.
>
> >> Regarding teh Java code, I suggest we keep what you have (likely Java
> code convention), we can vote later on keep it or moving globally to
> another convention.
> I do like the current one that can be most easily setup in IDEA or Eclipse
> in my view and is also very concise/compact in lines, but sure I would
> follow the best practice if we vote one. The major concern would be we have
> to find/write a tool to convert the existing codes to use the new style if
> we have to change.
>
> Current codes follow in the following style I copied from IDEA template.
> ===
> public class Foo {
> public int[] X = new int[]{1, 3, 5 7, 9, 11};
>
> public void foo(boolean a, int x, int y, int z) {
> label1:
> do {
> try {
> if (x > 0) {
> int someVariable = a ? x : y;
> int anotherVariable = a ? x : y;
> } else if (x < 0) {
> int someVariable = (y + z);
> someVariable = x = x + y;
> } else {
> label2:
> for (int i = 0; i < 5; i++) doSomething(i);
>
the above block certainly hurts my eyes ;)
I will be very glad if we all decide to use the format that is used in all
sub-projects.
> }
> switch (a) {
> case 0:
> doCase0();
> break;
> default:
> doDefault();
> }
> } catch (Exception e) {
> processException(e.getMessage(), x + y, z, a);
> } finally {
> processFinally();
> }
> }
> while (true);
>
> if (2 < 3) return;
> if (3 < 4) return;
> do {
> x++
> }
> while (x < 10000);
> while (x < 50000) x++;
> for (int i = 0; i < 5; i++) System.out.println(i);
> }
>
> private class InnerClass implements I1, I2 {
> public void bar() throws E1, E2 {
> }
> }
> }
> ===
>
> Regards,
> Kai
>
> -----Original Message-----
> From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
> Sent: Monday, January 12, 2015 11:44 PM
> To: Apache Directory Developers List
> Subject: Re: [kerby/haox] Dependencies updates needed
>
> Le 12/01/15 09:57, Zheng, Kai a écrit :
> > Hi Emmanuel,
> >
> > I have checked the great changes in the new branch. Would you mind I
> make some slight adjustment to make the style consistent with the existing
> codes before I merge them in? Thanks.
>
> Sure.
>
> I don't like 4 spaces for XML files, it's quickly too wide, I use 2 spaces.
>
> Regarding teh Java code, I suggest we keep what you have (likely Java code
> convention), we can vote later on keep it or moving globally to another
> convention.
>
>
--
Kiran Ayyagari
http://keydap.com
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2 spaces.
Agree, let's follow this.
>> Regarding teh Java code, I suggest we keep what you have (likely Java code convention), we can vote later on keep it or moving globally to another convention.
I do like the current one that can be most easily setup in IDEA or Eclipse in my view and is also very concise/compact in lines, but sure I would follow the best practice if we vote one. The major concern would be we have to find/write a tool to convert the existing codes to use the new style if we have to change.
Current codes follow in the following style I copied from IDEA template.
===
public class Foo {
public int[] X = new int[]{1, 3, 5 7, 9, 11};
public void foo(boolean a, int x, int y, int z) {
label1:
do {
try {
if (x > 0) {
int someVariable = a ? x : y;
int anotherVariable = a ? x : y;
} else if (x < 0) {
int someVariable = (y + z);
someVariable = x = x + y;
} else {
label2:
for (int i = 0; i < 5; i++) doSomething(i);
}
switch (a) {
case 0:
doCase0();
break;
default:
doDefault();
}
} catch (Exception e) {
processException(e.getMessage(), x + y, z, a);
} finally {
processFinally();
}
}
while (true);
if (2 < 3) return;
if (3 < 4) return;
do {
x++
}
while (x < 10000);
while (x < 50000) x++;
for (int i = 0; i < 5; i++) System.out.println(i);
}
private class InnerClass implements I1, I2 {
public void bar() throws E1, E2 {
}
}
}
===
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 11:44 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 12/01/15 09:57, Zheng, Kai a écrit :
> Hi Emmanuel,
>
> I have checked the great changes in the new branch. Would you mind I make some slight adjustment to make the style consistent with the existing codes before I merge them in? Thanks.
Sure.
I don't like 4 spaces for XML files, it's quickly too wide, I use 2 spaces.
Regarding teh Java code, I suggest we keep what you have (likely Java code convention), we can vote later on keep it or moving globally to another convention.
Re: [kerby/haox] Dependencies updates needed
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 12/01/15 09:57, Zheng, Kai a écrit :
> Hi Emmanuel,
>
> I have checked the great changes in the new branch. Would you mind I make some slight adjustment to make the style consistent with the existing codes before I merge them in? Thanks.
Sure.
I don't like 4 spaces for XML files, it's quickly too wide, I use 2 spaces.
Regarding teh Java code, I suggest we keep what you have (likely Java
code convention), we can vote later on keep it or moving globally to
another convention.
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
Hi Emmanuel,
I have merged your changes into the master, and refactored a little bit. Please let me know if anything I missed. Thanks.
Regards,
Kai
-----Original Message-----
From: Zheng, Kai [mailto:kai.zheng@intel.com]
Sent: Monday, January 12, 2015 4:58 PM
To: Apache Directory Developers List
Subject: RE: [kerby/haox] Dependencies updates needed
Hi Emmanuel,
I have checked the great changes in the new branch. Would you mind I make some slight adjustment to make the style consistent with the existing codes before I merge them in? Thanks.
About the test splitting, there're quite a few other cases like the one you changed. I agree with your approach. Would like more help from other contributors to get them done also. Will ask for help from new contributors.
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 4:01 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>
>>> I just check for the dependencies use by Kerby/Haox, there are a few
>>> that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?
Atm, I have created a branch (maven-refactor) in which I have updated the deps. Feel free to check it and merge it back to master if it's ok.
I also have injected an updated test class, where I split the various tests into atomic ones, to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is now compliant with hat we should have for all the project's classes (don't expect such a task to be funny, but we have to go through this class after the other, in the coming weeks).
Thanks !
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
Hi Emmanuel,
I have checked the great changes in the new branch. Would you mind I make some slight adjustment to make the style consistent with the existing codes before I merge them in? Thanks.
About the test splitting, there're quite a few other cases like the one you changed. I agree with your approach. Would like more help from other contributors to get them done also. Will ask for help from new contributors.
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 4:01 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>
>>> I just check for the dependencies use by Kerby/Haox, there are a few
>>> that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?
Atm, I have created a branch (maven-refactor) in which I have updated the deps. Feel free to check it and merge it back to master if it's ok.
I also have injected an updated test class, where I split the various tests into atomic ones, to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is now compliant with hat we should have for all the project's classes (don't expect such a task to be funny, but we have to go through this class after the other, in the coming weeks).
Thanks !
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
About the Apache license header issue, have discussed with Lin chen. She would love to do it for all. Thanks!
Regards,
Kai
-----Original Message-----
From: Zheng, Kai [mailto:kai.zheng@intel.com]
Sent: Monday, January 12, 2015 4:27 PM
To: Apache Directory Developers List
Subject: RE: [kerby/haox] Dependencies updates needed
Thanks Emmanuel. I see.
>> I also added the missing Apache header and Javadoc, ...
Ah, yes, we need get it done. Will have a JIRA for it. Let's see if any new contributor would help with this important work.
Will check your codes and merge them in. Thanks!
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 4:01 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>
>>> I just check for the dependencies use by Kerby/Haox, there are a few
>>> that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?
Atm, I have created a branch (maven-refactor) in which I have updated the deps. Feel free to check it and merge it back to master if it's ok.
I also have injected an updated test class, where I split the various tests into atomic ones, to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is now compliant with hat we should have for all the project's classes (don't expect such a task to be funny, but we have to go through this class after the other, in the coming weeks).
Thanks !
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
Thanks Emmanuel. I see.
>> I also added the missing Apache header and Javadoc, ...
Ah, yes, we need get it done. Will have a JIRA for it. Let's see if any new contributor would help with this important work.
Will check your codes and merge them in. Thanks!
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 4:01 PM
To: Apache Directory Developers List
Subject: Re: [kerby/haox] Dependencies updates needed
Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>
>>> I just check for the dependencies use by Kerby/Haox, there are a few
>>> that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?
Atm, I have created a branch (maven-refactor) in which I have updated the deps. Feel free to check it and merge it back to master if it's ok.
I also have injected an updated test class, where I split the various tests into atomic ones, to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is now compliant with hat we should have for all the project's classes (don't expect such a task to be funny, but we have to go through this class after the other, in the coming weeks).
Thanks !
Re: [kerby/haox] Dependencies updates needed
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 12/01/15 04:15, Zheng, Kai a écrit :
> Hi Emmanuel,
>
>>> I just check for the dependencies use by Kerby/Haox, there are a few that require to be bumped up
> Thanks for taking care of this. What tasks are involved here?
Atm, I have created a branch (maven-refactor) in which I have updated
the deps. Feel free to check it and merge it back to master if it's ok.
I also have injected an updated test class, where I split the various
tests into atomic ones, to better see what are the failing tests, "à la"
Junit way, instead of having one single test running all the test cases.
I also added the missing Apache header and javadoc, so that the class is
now compliant with hat we should have for all the project's classes
(don't expect such a task to be funny, but we have to go through this
class after the other, in the coming weeks).
Thanks !
RE: [kerby/haox] Dependencies updates needed
Posted by "Zheng, Kai" <ka...@intel.com>.
Hi Emmanuel,
>> I just check for the dependencies use by Kerby/Haox, there are a few that require to be bumped up
Thanks for taking care of this. What tasks are involved here?
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, January 12, 2015 2:09 AM
To: Apache Directory Developers List
Subject: [kerby/haox] Dependencies updates needed
Hi,
I just check for the dependencies use by Kerby/Haox, there are a few that require to be bumped up :
[INFO] Building Haox Project 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Third Party Projects 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building not-yet-commons-ssl 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] commons-httpclient:commons-httpclient ..................... 3.0
-> 3.1
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] log4j:log4j ......................................... 1.2.13 ->
1.2.17
[INFO] org.mockito:mockito-all .......................... 1.9.5 ->
2.0.2-beta
[INFO]
[INFO] Building Contrib Projects 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-config 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] org.slf4j:slf4j-api .................................. 1.7.5 ->
1.7.10
[INFO]
[INFO] Building Haox Event 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-asn1 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox PKIX 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-token Project 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] com.nimbusds:nimbus-jose-jwt .............................. 3.2
-> 3.5
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Project 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb core 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Crypto 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Util 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building haox-kerb-coreTest 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Common 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Identity 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Client 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb Server 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kerb-KdcTest 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox-kdc Project 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Ldap identity backend 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox KDC Server 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Tools 1.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] The following dependencies in Dependencies have newer versions:
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO]
[INFO] Building Haox benchmark 1.0-SNAPSHOT [INFO]
------------------------------------------------------------------------
[INFO]
[INFO] junit:junit ............................................ 4.8.2
-> 4.12
[INFO] org.apache.directory.api:api-all .............. 1.0.0-M20 ->
1.0.0-M27
[INFO] org.apache.directory.server:apacheds-core-api ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-interceptor-kerberos ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-ldif-partition ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-mavibot-partition ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-protocol-kerberos ...
[INFO] 2.0.0-M15 ->
2.0.0-M19
[INFO] org.apache.directory.server:apacheds-protocol-shared ...
[INFO] 2.0.0-M15 ->
2.0.0-M19