[GitHub] [couchdb] davisp commented on issue #2319: Implement node types

[GitBox <gi...@apache.org>]

davisp commented on issue #2319: Implement node types
URL: https://github.com/apache/couchdb/pull/2319#issuecomment-557173764
 
 
   Generally speaking this looks fine to me. Though two quick questions:
   
   In chttpd you modified the supervision tree where as in couch_views you modify the worker. Why the inconsistency?
   
   Also, why modify the children to have an empty supervisor instead of gating it around the `supervisor:start_link` call? (i.e., just don't start the entire tree rather than having an empty supervisor?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services