[GitHub] [spark] yuj commented on a change in pull request #29934: [SPARK-32067][k8s] Give pod template configmap a unique name

[GitBox <gi...@apache.org>]

yuj commented on a change in pull request #29934:
URL: https://github.com/apache/spark/pull/29934#discussion_r499163210



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
##########
@@ -85,3 +103,7 @@ private[spark] class PodTemplateConfigMapStep(conf: KubernetesConf)
     }
   }
 }
+
+private[spark] object PodTemplateConfigMapStep {
+  val PODSPEC_CONFIGMAP_POSTFIX = "-podspec-configmap"
+}

Review comment:
       Please use the constant already defined in Constants.scala
   `val POD_TEMPLATE_CONFIGMAP = "podspec-configmap"`

##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
##########
@@ -56,8 +60,10 @@ class PodTemplateConfigMapStepSuite extends SparkFunSuite {
 
     assert(configuredPod.pod.getSpec.getVolumes.size() === 1)
     val volume = configuredPod.pod.getSpec.getVolumes.get(0)
+    val generatedResourceName = kubernetesConf.resourceNamePrefix +
+      PodTemplateConfigMapStep.PODSPEC_CONFIGMAP_POSTFIX

Review comment:
       Same as the suggestion above, should use the constant already defined in Constants.scala.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org