[jira] [Commented] (FLINK-10770) Some generated functions are not opened properly.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674050#comment-16674050 ] 

ASF GitHub Bot commented on FLINK-10770:
----------------------------------------

jrthe42 opened a new pull request #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.
URL: https://github.com/apache/flink/pull/7014
 
 
   ## What is the purpose of the change
   When transforming sql to execution plan, some generated functions' `open` method are not called., this may cause exception if the UDFs need be opened. This PR fix this issue.
   
   ## Brief change log
    - Call `open` method after generated functions are complied and instantiated.
   
   ## Verifying this change
   This change added tests and can be verified as follows:
     - org.apache.flink.table.runtime.stream.table.UdfITCase
     - org.apache.flink.table.runtime.batch.table.UdfITCase
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not** applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Some generated functions are not opened properly.
> -------------------------------------------------
>
>                 Key: FLINK-10770
>                 URL: https://issues.apache.org/jira/browse/FLINK-10770
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.6.2, 1.7.0
>            Reporter: wangsan
>            Assignee: wangsan
>            Priority: Major
>              Labels: pull-request-available
>
> Recently I found sometimes UDFs are not open properly. It turns out when transforming sql to execution plan, some generated functions' *open* method are not called. e.g. *NonWindowJoin*, *TimeBoundedStreamJoin*, *FlatJoinRunner*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)