You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2015/02/27 10:24:28 UTC
[DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Hi,
this is the discussion thread to the matching vote. Please place any discussions here.
Chris
AW: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Christofer Dutz <ch...@c-ware.de>.
Ah ... ok ... so that's easy ... now the name will be apache-flex-blazeds-{version}
I also saw that I had already prepared the creation of a zip and tar-gz source distribution, all I have to do is activate another maven profile ... will definitely do that for RC2
Chris
-----Ursprüngliche Nachricht-----
Von: Justin Mclean [mailto:justin@classsoftware.com]
Gesendet: Sonntag, 1. März 2015 15:20
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Hi,
> Thinking about it again I think we don't need the "apache" in front of the artifact as it's allready part of the groupId.
I was referring to the name of the of the source zip file. Having apache in the name gives a little more legal protection, but it's not a requirement.
Justin
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Thinking about it again I think we don't need the "apache" in front of the artifact as it's allready part of the groupId.
I was referring to the name of the of the source zip file. Having apache in the name gives a little more legal protection, but it's not a requirement.
Justin
AW: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Christofer Dutz <ch...@c-ware.de>.
Thinking about it again I think we don't need the "apache" in front of the artifact as it's allready part of the groupId. The official name of the artifact is:
Org.apache.flex.blazeds:flex-messaging-{module}
So I don't think we need the "apache" in the artifact name again ... and with the flex-tools-api we also didnt append the "apache" ... what do the others think?
Chris
-----Ursprüngliche Nachricht-----
Von: Justin Mclean [mailto:justin@classsoftware.com]
Gesendet: Sonntag, 1. März 2015 11:09
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Hi,
> - I tagged the release RC1 cause it was the RC1 and I remember having trouble deleting and re-adding a tag. If it's not a problem to delete a tag, I'd be glad to change this.
No issue with the tag in git, it's the fact that it part of the release that's an issue. The pom.xml in the release can't be modified without changing the signatures and hashes.
> - Do you suggest to call the artifacts "apache-flex-messageing-{module}"? What do the others think about this? How about changing that to from "flex-messaging" to "apache-blazeds"?
Sounds good to me and not a blocker anyway.
> - Didn't Alex change this to 20XX-2015? Gee ... just saw this was only on the NOTICE in the root ... not the modules directory :-(
Again not a blocker.
Thanks,
Justin
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> - I tagged the release RC1 cause it was the RC1 and I remember having trouble deleting and re-adding a tag. If it's not a problem to delete a tag, I'd be glad to change this.
No issue with the tag in git, it's the fact that it part of the release that's an issue. The pom.xml in the release can't be modified without changing the signatures and hashes.
> - Do you suggest to call the artifacts "apache-flex-messageing-{module}"? What do the others think about this? How about changing that to from "flex-messaging" to "apache-blazeds"?
Sounds good to me and not a blocker anyway.
> - Didn't Alex change this to 20XX-2015? Gee ... just saw this was only on the NOTICE in the root ... not the modules directory :-(
Again not a blocker.
Thanks,
Justin
AW: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Justin,
thanks for looking into this. I'll go through your comments one by one:
- I tagged the release RC1 cause it was the RC1 and I remember having trouble deleting and re-adding a tag. If it's not a problem to delete a tag, I'd be glad to change this.
- Do you suggest to call the artifacts "apache-flex-messageing-{module}"? What do the others think about this? How about changing that to from "flex-messaging" to "apache-blazeds"?
- Didn't Alex change this to 20XX-2015? Gee ... just saw this was only on the NOTICE in the root ... not the modules directory :-(
- I removed the part about the bugfixes in the Readme, as not a single real bugfix was applied since the donation. What happened before that ... I don't know.
- Adjusted the README to no longer reference the modules directory
- Found another problem in the README in which I referenced the "Flex Tool API" instead of "Apache BlazeDS" ... fixed that too.
I'll wait another day till I spin up another RC assuming that your +0 will become a +1 as soon as these things are addressed and I want to give others a chance to find more stuff.
Chris
-----Ursprüngliche Nachricht-----
Von: Justin Mclean [mailto:justin@classsoftware.com]
Gesendet: Sonntag, 1. März 2015 08:13
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Hi,
One thing I did noticed about the code is the large number of @author tags. This is generally frowned on in Apache. [1][2] Should we remove them?
Thanks,
Justin
1. http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt (read 7F)
2 http://opensource.com/law/14/2/copyright-statements-source-files
AW: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Christofer Dutz <ch...@c-ware.de>.
No objections from my side.
Chris
Gesendet mit meinem HTC
----- Reply message -----
Von: "Justin Mclean" <ju...@classsoftware.com>
An: "dev@flex.apache.org" <de...@flex.apache.org>
Betreff: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Datum: Mo., Mär. 2, 2015 08:22
Hi,
> If it’s making you itch, go ahead and scratch it.
Anyone else have any objections to removing them? If not and once I have time I'll remove them.
Thanks,
Justin
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> If it’s making you itch, go ahead and scratch it.
Anyone else have any objections to removing them? If not and once I have time I'll remove them.
Thanks,
Justin
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Alex Harui <ah...@adobe.com>.
On 2/28/15, 11:12 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>One thing I did noticed about the code is the large number of @author
>tags. This is generally frowned on in Apache. [1][2] Should we remove
>them?
If it’s making you itch, go ahead and scratch it.
-Alex
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
One thing I did noticed about the code is the large number of @author tags. This is generally frowned on in Apache. [1][2] Should we remove them?
Thanks,
Justin
1. http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt (read 7F)
2 http://opensource.com/law/14/2/copyright-statements-source-files
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
I taken a look and there's possibly an issue, while very minor, may require another RC being made. :-(
The pom file containing a tag containing RC1. This is included in the release artefact and can't be change without changing the hashes/resigning etc
<tag>blazeds-4.7.0.0-RC1</tag>
Thanks,
Justin
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
When reviewing I also noticed these two files:
./proxy/src/flex/messaging/services/http/httpclient/EasySSLProtocolSocketFactory.java
./proxy/src/flex/messaging/services/http/httpclient/EasyX509TrustManager.java
I believe both are form the Apache Jakarta project so there no issue re LICENSE/NOTICE, just a little surprised re the headers.
Thanks,
Justin
AW: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Christofer Dutz <ch...@c-ware.de>.
Unfortunately not that I am aware of.
I have tested it by switching my projects, that I have BlazeDS running in to the new version and they worked perfectly.
Chris
________________________________________
Von: Tom Chiverton <tc...@extravision.com>
Gesendet: Freitag, 27. Februar 2015 12:12
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Are there any quick and easy example projects to test it with ?
Tom
On 27/02/15 09:24, Christofer Dutz wrote:
> Hi,
>
>
> this is the discussion thread to the matching vote. Please place any discussions here.
>
>
> Chris
>
> ______________________________________________________________________
> This email has been scanned by the Symantec Email Security.cloud service.
> For more information please visit http://www.symanteccloud.com
> ______________________________________________________________________
Re: [DISCUSS] [BlazeDS] Release of Apache BlazeDS 4.7.0.0 RC1
Posted by Tom Chiverton <tc...@extravision.com>.
Are there any quick and easy example projects to test it with ?
Tom
On 27/02/15 09:24, Christofer Dutz wrote:
> Hi,
>
>
> this is the discussion thread to the matching vote. Please place any discussions here.
>
>
> Chris
>
> ______________________________________________________________________
> This email has been scanned by the Symantec Email Security.cloud service.
> For more information please visit http://www.symanteccloud.com
> ______________________________________________________________________