[jira] [Commented] (HIVE-8583) HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist

["Lars Francke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182050#comment-14182050 ] 

Lars Francke commented on HIVE-8583:
------------------------------------

I'm not sure if the default value reading stuff is needed or if it'll somehow be propagated to the Configuration object in some other way....

> HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
> ---------------------------------------------------------------
>
>                 Key: HIVE-8583
>                 URL: https://issues.apache.org/jira/browse/HIVE-8583
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-8583.1.patch
>
>
> [~alangates] added the following in HIVE-8341:
> {code}
>         String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
>         if (bl != null && bl.length() > 0) {
>           String[] bls = bl.split(",");
>           for (String b : bls) {
>             b.replaceAll(".", "_");
>             blackListedConfEntries.add(b);
>           }
>         }
> {code}
> The {{replaceAll}} call is confusing as its result is not used at all.
> This patch contains the following:
> * Minor style modification (missorted modifiers)
> * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
> * Removes replaceAll
> * Lets blackListed take a Configuration job as parameter which allowed me to add a test for this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)