You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Sami Siren (JIRA)" <ji...@apache.org> on 2009/12/16 08:04:18 UTC
[jira] Created: (NUTCH-775) Enhance Searcher interface
Enhance Searcher interface
--------------------------
Key: NUTCH-775
URL: https://issues.apache.org/jira/browse/NUTCH-775
Project: Nutch
Issue Type: Improvement
Components: searcher
Reporter: Sami Siren
Assignee: Sami Siren
Fix For: 1.1
Current Searcher interface is too limited for many purposes:
Hits search(Query query, int numHits, String dedupField, String sortField,
boolean reverse) throws IOException;
It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
Hits search(Query query, Metadata context) throws IOException;
Also at the same time we should enhance the QueryFilter interface to look something like:
BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
throws QueryException;
I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-775) Enhance Searcher interface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828459#action_12828459 ]
Hudson commented on NUTCH-775:
------------------------------
Integrated in Nutch-trunk #1058 (See [http://hudson.zones.apache.org/hudson/job/Nutch-trunk/1058/])
Enhance Searcher interface
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-775) Enhance Searcher interface
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806031#action_12806031 ]
Andrzej Bialecki commented on NUTCH-775:
-----------------------------------------
IMHO this could go as it is ... one suggestion though: this Query/QueryContext now resembles SolrQuery/SolrParams. Perhaps we could rename QueryContext to QueryParams?
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-775) Enhance Searcher interface
Posted by "Sami Siren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806051#action_12806051 ]
Sami Siren commented on NUTCH-775:
----------------------------------
{quote}IMHO this could go as it is ... one suggestion though: this Query/QueryContext now resembles SolrQuery/SolrParams. Perhaps we could rename QueryContext to QueryParams?
{quote}
That sounds reasonable, I will change the name before committing. Also I forgot to change web gui to use the new api, will do that also.
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-775) Enhance Searcher interface
Posted by "Sami Siren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806019#action_12806019 ]
Sami Siren commented on NUTCH-775:
----------------------------------
If there are no objections I'll commit the proposed patch within few days.
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
unsubscribe
Posted by Futebol DotInfo <fu...@yahoo.com>.
unsubscribe
--- On Wed, 12/30/09, Sami Siren (JIRA) <ji...@apache.org> wrote:
From: Sami Siren (JIRA) <ji...@apache.org>
Subject: [jira] Updated: (NUTCH-775) Enhance Searcher interface
To: nutch-dev@lucene.apache.org
Date: Wednesday, December 30, 2009, 11:09 AM
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sami Siren updated NUTCH-775:
-----------------------------
Attachment: NUTCH-775.patch
I ended up changing the Query API instead since the changes were smaller from API perspective that way.
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-775) Enhance Searcher interface
Posted by "Sami Siren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sami Siren updated NUTCH-775:
-----------------------------
Attachment: NUTCH-775.patch
I ended up changing the Query API instead since the changes were smaller from API perspective that way.
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (NUTCH-775) Enhance Searcher interface
Posted by "Sami Siren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sami Siren resolved NUTCH-775.
------------------------------
Resolution: Fixed
I committed this
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
> Attachments: NUTCH-775.patch
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-775) Enhance Searcher interface
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791411#action_12791411 ]
Andrzej Bialecki commented on NUTCH-775:
-----------------------------------------
+1. I would suggest creating a subclass of Metadata, where we can guarantee the presence of some required parameters, e.g.:
{code}
public class SearchContext extends Metadata {
protected int numHits;
protected String sortField;
protected String dedupField;
...
// setters and getters for the above
}
{code}
and change the QueryFilter interface to use SearchContext too.
> Enhance Searcher interface
> --------------------------
>
> Key: NUTCH-775
> URL: https://issues.apache.org/jira/browse/NUTCH-775
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Reporter: Sami Siren
> Assignee: Sami Siren
> Fix For: 1.1
>
>
> Current Searcher interface is too limited for many purposes:
> Hits search(Query query, int numHits, String dedupField, String sortField,
> boolean reverse) throws IOException;
> It would be nice that we had an interface that allowed adding different features without changing the interface. I am proposing that we deprecate the current search method and introduce something like:
> Hits search(Query query, Metadata context) throws IOException;
> Also at the same time we should enhance the QueryFilter interface to look something like:
> BooleanQuery filter(Query input, BooleanQuery translation, Metadata context)
> throws QueryException;
> I would like to hear your comments before proceeding with a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.