You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2015/12/09 22:16:00 UTC

Review Request 41149: Drop the distinction from the UI and always show upgrade as "Paused" rather than "Aborted"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41149/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-14280
    https://issues.apache.org/jira/browse/AMBARI-14280


Repository: ambari


Description
-------

When the upgrade state is "ABORTED", should always show yellow "Upgrade Paused" in UI, and treat as upgrade paused, so that user can resume upgrade.


Diffs
-----

  ambari-web/app/app.js b2f97af 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js ff5bf3d 
  ambari-web/app/messages.js ff10f70 
  ambari-web/app/models/upgrade_entity.js ab9806a 
  ambari-web/app/templates/application.hbs 0a8309a 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 32c457d 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1be4290 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ed22325 
  ambari-web/test/app_test.js dd58d46 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js d1d5761 
  ambari-web/test/models/upgrade_entity_test.js 05f1278 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 9bf8a71 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js 7505282 

Diff: https://reviews.apache.org/r/41149/diff/


Testing
-------

Tested manually e2e. ALL UT passed.


Thanks,

Xi Wang


Re: Review Request 41149: Drop the distinction from the UI and always show upgrade as "Paused" rather than "Aborted"

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41149/#review109635
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Dec. 9, 2015, 9:15 p.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41149/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 9:15 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14280
>     https://issues.apache.org/jira/browse/AMBARI-14280
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When the upgrade state is "ABORTED", should always show yellow "Upgrade Paused" in UI, and treat as upgrade paused, so that user can resume upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/app.js b2f97af 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js ff5bf3d 
>   ambari-web/app/messages.js ff10f70 
>   ambari-web/app/models/upgrade_entity.js ab9806a 
>   ambari-web/app/templates/application.hbs 0a8309a 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 32c457d 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 1be4290 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ed22325 
>   ambari-web/test/app_test.js dd58d46 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js d1d5761 
>   ambari-web/test/models/upgrade_entity_test.js 05f1278 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 9bf8a71 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js 7505282 
> 
> Diff: https://reviews.apache.org/r/41149/diff/
> 
> 
> Testing
> -------
> 
> Tested manually e2e. ALL UT passed.
> 
> 
> Thanks,
> 
> Xi Wang
> 
>