You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/08 04:15:58 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #22003: Refactor logback config by Java spi
Pace2Car opened a new pull request, #22003:
URL: https://github.com/apache/shardingsphere/pull/22003
Changes proposed in this pull request:
- Add Java spi logback config
- Remove default config file logback.xml
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308343074
> > Hi @terrymanu @TeslaCN We think that Proxy acts as a database, however there is no database that requires the user to configure the log level to start working properly.
>
> About that, could Proxy start without `server.yaml`?
If it is a standalone Proxy, it is now possible to have no server.yaml.
In the case of cluster mode, the user needs a configuration to connect to the governance center.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308340216
> Hi @terrymanu @TeslaCN We think that Proxy acts as a database, however there is no database that requires the user to configure the log level to start working properly.
>
About that, could Proxy start without `server.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308199753
> @terrymanu Use xml file is still the preferred option, add java code to provide the default configuration.
Maybe it is better to use xml as default log format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Pace2Car commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
Pace2Car commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308126906
@terrymanu Use xml file is still the preferred option, add java code to provide the default configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308355149
If server.yaml is not required in Standalone mode. They don't have to mount anything. There is already a logback.xml in conf. If users don't intend to change log configuration, they could just keep the origin one.
On one hand, if they want to mount something into container, users can also keep the origin logback.xml.
On the other hand, if they want to change log configuration, users can copy the origin one from containers instead of creating one from scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #22003: Refactor logback config by Java spi
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22003:
URL: https://github.com/apache/shardingsphere/pull/22003#issuecomment-1308335793
Hi @terrymanu @TeslaCN
We think that Proxy acts as a database, however there is no database that requires the user to configure the log level to start working properly.
**This PR provides a possibility:**
Proxy can work according to the default log level without `logback.xml` configuration.
For example, when we deploy Proxy to a container, we need to mount a `conf/` directory, and then the `conf/` directory can have no `logback.xml`.
Of course, according to the configuration order of logback, users can use xml to meet their individual needs.
At the same time, I think there is room for improvement, for example, the configuration of logger may be stored in global rule, so that we can modify the log configuration of the whole cluster at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org