[jira] Commented: (MSITE-358) site.xml urls are not always correct

["John Allen (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MSITE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157108#action_157108 ] 

John Allen commented on MSITE-358:
----------------------------------

Over enthusiatsic application or resolveRelativeLinks, probably in assembleInheritance. However the same 'issue' applies to <modules> and parent URLs. relatives URLs are used where ever possible so that you can stage a collection of projects together and they will link to each other but eventually you'll hit a parent say that you've not staged but, if you were deploying to the real location, would be available via a relative, and that link will therefore be invalid in your staged environment. 

I presume you're refering to site:stage in this. 

I note in the banners those are full URLs and not relatives. What if they were relatives? If my parent site.xml defined that it uses .,/images/foo what should the child have for those resource locations? Is it true that the it will be using the same skin? it may be inherting the parent's site.xml but it could it not be using its own skin that does not contain that specifc image? Is multiple inheritence of skins allowed or does the child's skin override the parents? If its the later then what resource indicator is correct for an image that only exists in the parent? 

I expect just not changing them to relatives would best. 


> site.xml urls are not always correct
> ------------------------------------
>
>                 Key: MSITE-358
>                 URL: http://jira.codehaus.org/browse/MSITE-358
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: Brian Fox
>            Priority: Blocker
>             Fix For: 2.0-beta-8
>
>
> This is so completely broken that it must be fixed before another release occurs. 
> The maven-parent site.xml defines some images as:
> {noformat}
>   <bannerLeft>
>     <name>${project.name}</name>
>     <src>http://maven.apache.org/images/apache-maven-project-2.png</src>
>     <href>http://maven.apache.org/</href>
>   </bannerLeft>
>   <bannerRight>
>     <src>http://maven.apache.org/images/maven-logo-2.gif</src>
>   </bannerRight>
> {noformat}
> The site plugin somewhere along the line replaces these urls with ../../ repeated based on how far down the inheritence tree you are from maven-parent. This means you can't stage or deploy a site to a different location than the maven-parent because all urls will point back to maven-parent's /images. Worse, every module has its own copy of the css and images so there's no reason for it to depend on the parent at all.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira