You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/19 20:17:00 UTC

[GitHub] [airflow] mik-laj edited a comment on issue #11657: Better unit tests for Helm Chart

mik-laj edited a comment on issue #11657:
URL: https://github.com/apache/airflow/issues/11657#issuecomment-712315157


   To be precise, [terratest](https://terratest.gruntwork.io/docs/getting-started/quick-start/) is just a library that provides a set of functions that make it easier to write tests, but it is not a full framework. You can use any framework, but the documentation recommends using Go’s built-in [package testing](https://golang.org/pkg/testing/). The module of interest for us is: 
   (`modules/helm/template.go`)[https://github.com/gruntwork-io/terratest/blob/master/modules/helm/template.go]
   
   So now we have discussions as to which we want to use one of the following set of tools.
   - `pytest` as a test runner, `unittest.TestCase` as a framework (most likely) and one of our own functions, 
   - `go test` command as a test runner, `go/pkg/testing` as a framework, and `terratest` with a ready function.
   
   I don't think we use any unique golang features (good asynchronous libraries, security, etc.) on the other hand, Python is a language valued for its simple syntax and user-friendliness. I would like to add that currently the integration tests for Helm Chart are also written in Python.
   
   What are the benefits of Golang in our case? The potential popularity with other contributors is a benefit, but I don't see them being active in the development of this Helm Chart. Rather, new features are being added by active contributors to the project who are already familiar with Python. However, if someone is not familiar with Python, writing new tests should not be a challenge for him, because Python is simpler than golang.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org