You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/29 10:16:18 UTC
[GitHub] [skywalking] JaredTan95 opened a new pull request #4428: fix e2e
miss.
JaredTan95 opened a new pull request #4428: fix e2e miss.
URL: https://github.com/apache/skywalking/pull/4428
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
https://github.com/apache/skywalking/pull/4197
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4428: fix agent
auth e2e not activated.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592932612
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=h1) Report
> Merging [#4428](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/036aee8d2cfd83afecfc43b5e5d7b8e288122efb?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4428 +/- ##
==========================================
- Coverage 25.14% 25.11% -0.03%
==========================================
Files 1211 1211
Lines 28078 28078
Branches 3864 3864
==========================================
- Hits 7059 7051 -8
- Misses 20370 20377 +7
- Partials 649 650 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55% <0%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=footer). Last update [036aee8...cc98357](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4428: fix agent auth
e2e not activated.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592940445
yeah, I am looking for where to set ` -Dskywalking.agent.authentication=test-token` and make it affect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4428: fix agent auth e2e
not activated.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592939794
Seems auth check is going to fail again. 17m passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4428: fix agent
auth e2e not activated.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592932612
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=h1) Report
> Merging [#4428](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/036aee8d2cfd83afecfc43b5e5d7b8e288122efb?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4428 +/- ##
==========================================
- Coverage 25.14% 25.11% -0.03%
==========================================
Files 1211 1211
Lines 28078 28078
Branches 3864 3864
==========================================
- Hits 7059 7052 -7
- Misses 20370 20377 +7
Partials 649 649
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=footer). Last update [036aee8...cc98357](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4428: fix agent
auth e2e not activated.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592932612
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=h1) Report
> Merging [#4428](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/036aee8d2cfd83afecfc43b5e5d7b8e288122efb?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4428 +/- ##
=======================================
Coverage 25.14% 25.14%
=======================================
Files 1211 1211
Lines 28078 28078
Branches 3864 3864
=======================================
Hits 7059 7059
Misses 20370 20370
Partials 649 649
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=footer). Last update [036aee8...c263d13](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4428: fix agent
auth e2e not activated.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592932612
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=h1) Report
> Merging [#4428](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/036aee8d2cfd83afecfc43b5e5d7b8e288122efb?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4428 +/- ##
==========================================
- Coverage 25.14% 25.11% -0.03%
==========================================
Files 1211 1211
Lines 28078 28078
Branches 3864 3864
==========================================
- Hits 7059 7051 -8
- Misses 20370 20377 +7
- Partials 649 650 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55% <0%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=footer). Last update [036aee8...cc98357](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4428: fix agent auth e2e
not activated.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4428: fix agent auth
e2e not activated.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592932612
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=h1) Report
> Merging [#4428](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/036aee8d2cfd83afecfc43b5e5d7b8e288122efb?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4428 +/- ##
==========================================
- Coverage 25.14% 25.11% -0.03%
==========================================
Files 1211 1211
Lines 28078 28078
Branches 3864 3864
==========================================
- Hits 7059 7052 -7
- Misses 20370 20377 +7
Partials 649 649
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4428/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=footer). Last update [036aee8...73b9838](https://codecov.io/gh/apache/skywalking/pull/4428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 removed a comment on issue #4428: fix agent
auth e2e not activated.
Posted by GitBox <gi...@apache.org>.
JaredTan95 removed a comment on issue #4428: fix agent auth e2e not activated.
URL: https://github.com/apache/skywalking/pull/4428#issuecomment-592940445
yeah, I am looking for where to set ` -Dskywalking.agent.authentication=test-token` and make it affect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services