[Bug 6362] [review] Change (urirhssub) mask syntax to netmask

[bu...@issues.apache.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6362

--- Comment #41 from Mark Martinec <Ma...@ijs.si> 2010-06-03 13:26:51 EDT ---
> > This has been released with 3.3.1, along the Spamhaus DBL support.
> > The test-case has been kept trunk only, because it requires adding a new config
> > option. See the comments I referenced earlier.
> 
> Ahh. Then I rescind my statement that a test case should be a blocker. However,
> it would be nice to get a test into 3.3.2.  

The change to DnsResolver.pm is nontrivial and adds new functionality - which
seems
plenty for a minor patch release like 3.3.2. Considering that the main need for
it is adding a test, and that there are three other DNS-related changes
targeted
for 3.4 (comment 31 and c32), I'd feel more comfortable if they'd go all
together
into 3.4. I don't consider absence of a test in 3.3 is warranting the
nontrivial
change in code. Also, the test is already in trunk and is being evaluated by
Hudson I believe.

> Is this something that would be a net_test and do you expect user configuration
> or a spamassassin project dictate of the config options?

Not sure I understand the question. The test spawns a self-contained DNS
resolver
with wired-in test zone. The missing (hereby added) functionality is to make
SA use that DNS server (for the test) instead of whatever is in
/etc/resolv.conf.
Don't know if that qualifies for a net test or not: it requires a working
TCP/IP stack on the loopback interface, but does not require network
connectivity.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.