You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Mathieu Lirzin (JIRA)" <ji...@apache.org> on 2018/10/28 19:04:00 UTC

[jira] [Commented] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

    [ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666521#comment-16666521 ] 

Mathieu Lirzin commented on OFBIZ-10451:
----------------------------------------

I have updated [^OFBIZ-10451_Use-String-equalsIgnoreCase-in-RequestHandler-doRequ.patch] to follow the 120 chars max guideline.

> Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’
> -------------------------------------------------------------
>
>                 Key: OFBIZ-10451
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10451
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10451_Use-String-equalsIgnoreCase-in-RequestHandler-doRequ.patch
>
>
> Use {{String::equalsIgnoreCase}}  instead of combining {{String::equals}} and {{String::toUpperCase}}. Additionally this avoids having to check the emptiness of the {{X-Forwarded-Proto}} request header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)