[GitHub] [netbeans] sdedic commented on a diff in pull request #4001: Fix WeakListener usage in Gradle modules

[GitBox <gi...@apache.org>]

sdedic commented on code in PR #4001:
URL: https://github.com/apache/netbeans/pull/4001#discussion_r852659307


##########
java/gradle.java/src/org/netbeans/modules/gradle/java/queries/GradleCompilerOptionsQuery.java:
##########
@@ -49,9 +49,8 @@ public final class GradleCompilerOptionsQuery implements CompilerOptionsQueryImp
 
     public GradleCompilerOptionsQuery(Project project) {
         this.project = project;
-        final NbGradleProject watcher = NbGradleProject.get(project);

Review Comment:
   Consider leaving the `watcher` instance and its usage here. The listener is attached to a certain NbGradleProject instance and receives events from it. With the change, it will check the **current** NbGradleProject instance which may be different from the one that actually fires the event. But maybe it's intentional ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists