[GitHub] justinmclean commented on issue #1672: Improve LICENSE and NOTICE according to ASF policy.

[GitBox <gi...@apache.org>]

justinmclean commented on issue #1672: Improve LICENSE and NOTICE according to ASF policy.
URL: https://github.com/apache/incubator-dubbo/pull/1672#issuecomment-384218935
 
 
   Looks good. Although I've not done a detailed check and would need a release tar ball to check. What's the best way to get a source tar bundle i.e. what exactly is going to be released and placed in the ASF release mirror system?
   
   A couple of very minor things.
   1. Re "This product bundles and repackages the following code in Google Guava 16.0.1, which is available under a Apache License 2.0" license. For details, see http://apache.org/licenses/LICENSE-2.0.txt." I would point to https://github.com/google/guava/blob/master/COPYING or better still exact version of that file for that release. (The master file could change in future versions)
   2. in NOTICE I'd put "Apache Dubbo (incubating)" rather than "Apache Dubbo"
   3. I'd put "Copyright 2018" rather than "Copyright 2018-2018"
   
   Both issues are trivial and wouldn't cause me to vote -1 on a release.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org