You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/10/10 22:29:45 UTC

[GitHub] activemq-artemis pull request #2364: ARTEMIS-1898 Proper fix on AtomicRunnab...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2364

    ARTEMIS-1898 Proper fix on AtomicRunnables and avoiding leaks

    GlobalDiskFullTest was broken before this fix.
    Basically when using multiple addresses over a session you would miss flow credits on all your producers except to the first one
    that ran out of credit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis tosend

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2364
    
----
commit 39a5701964e506bc81e653ef05296356e3fcb610
Author: Clebert Suconic <cl...@...>
Date:   2018-10-10T22:09:28Z

    ARTEMIS-1898 Proper fix on AtomicRunnables and avoiding leaks
    
    GlobalDiskFullTest was broken before this fix.
    Basically when using multiple addresses over a session you would miss flow credits on all your producers except to the first one
    that ran out of credit.

----


---

[GitHub] activemq-artemis issue #2364: ARTEMIS-1898 Proper fix on AtomicRunnables and...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2364
  
    I have the PR sent here for future conversations. But I plan to merge this myself as I am fixing the testsuite. I will wait the PR check and then merge it myself. (you have a short window if you disagree with something here. .but we can always change things later if you see anything wrong).


---

[GitHub] activemq-artemis pull request #2364: ARTEMIS-1898 Proper fix on AtomicRunnab...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2364


---