You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/21 11:53:09 UTC
[GitHub] [incubator-yunikorn-k8shim] kingamarton opened a new pull request #199: [YUNIKORN-447] Removed unnecessary log entry
kingamarton opened a new pull request #199:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #199: [YUNIKORN-447] Removed unnecessary log entry
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #199:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/199#issuecomment-713581017
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=h1) Report
> Merging [#199](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/013180f3c39182e61f8a2604525096e77d9b5f15?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 58.23% 58.29% +0.05%
==========================================
Files 33 33
Lines 2931 2928 -3
==========================================
Hits 1707 1707
+ Misses 1152 1149 -3
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `32.73% <ø> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=footer). Last update [013180f...198df47](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #199: [YUNIKORN-447] Removed unnecessary log entry
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #199:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/199#issuecomment-713581017
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=h1) Report
> Merging [#199](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/013180f3c39182e61f8a2604525096e77d9b5f15?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 58.23% 58.29% +0.05%
==========================================
Files 33 33
Lines 2931 2928 -3
==========================================
Hits 1707 1707
+ Misses 1152 1149 -3
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `32.73% <ø> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=footer). Last update [013180f...198df47](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #199: [YUNIKORN-447] Removed unnecessary log entry
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #199:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org