Deprecated code -- why not to mark it?

[Aleksandr Vinokurov <al...@gmail.com>]

Hello guys!

I'm moving my company's code from Xalan-c 1.10 to 1.11 (yes, I know it is
still in trunk but I'm forced to do this).

Despite of the lack of the migration document (maybe it will appear at
release) I noticed that deprecated code is marked only in javadoc but not in
code as with for ex.:

#ifndef DEPRECATED

#if defined(__GNUC__) && (__GNUC__ >= 4 || (__GNUC__==3 &&
__GNUC_MINOR__>=1))

#define DEPRECATED __attribute__((deprecated))

#elif defined(_MSC_VER) && _MSC_VER >= 1300

#define DEPRECATED __declspec(deprecated)

#else

#define DEPRECATED

#endif

#endif


I found it in
http://subversion.apache.org/docs/api/1.6/svn__types_8h-source.html

Please suggest it for release.


Aleksandr

Re: Deprecated code -- why not to mark it?

[David Bertoni <db...@apache.org>]

On 3/24/2010 3:21 AM, Aleksandr Vinokurov wrote:
>
>
> Hello guys!
>
> I'm moving my company's code from Xalan-c 1.10 to 1.11 (yes, I know it
> is still in trunk but I'm forced to do this).
>
> Despite of the lack of the migration document (maybe it will appear at
> release) I noticed that deprecated code is marked only in javadoc but
> not in code as with for ex.:
There's no reason why we couldn't do this. If you want to prepare a 
patch, please do so and attach it to a Jira issue.

Thanks!

Dave