You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:36:10 UTC

[GitHub] [pulsar] MarvinCai opened a new pull request, #16363: [Improvement][MLedger]Modernizer managed ledger

MarvinCai opened a new pull request, #16363:
URL: https://github.com/apache/pulsar/pull/16363

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   Master Issue: https://github.com/apache/pulsar/issues/12271
   
   ### Motivation
   Apply modernizer-maven-plugin maven plugin to encourage the use of modern & JDK builtin APIs.
   
   ### Modifications
   Add modernizer-maven-plugin plugin to managed-ledger module and fix violation by upgrading to suggested APIs.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   No real change to functionality, covered by existing unit tests.
   
   ### Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   - [x] `doc-not-needed` 
   No public client related changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] MarvinCai commented on pull request #16363: [Improvement][MLedger]Modernizer managed ledger

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on PR #16363:
URL: https://github.com/apache/pulsar/pull/16363#issuecomment-1192248018

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] MarvinCai closed pull request #16363: [Improvement][MLedger]Modernizer managed ledger

Posted by GitBox <gi...@apache.org>.
MarvinCai closed pull request #16363: [Improvement][MLedger]Modernizer managed ledger
URL: https://github.com/apache/pulsar/pull/16363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #16363: [Improvement][MLedger]Modernizer managed ledger

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16363:
URL: https://github.com/apache/pulsar/pull/16363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #16363: [Improvement][MLedger]Modernizer managed ledger

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16363:
URL: https://github.com/apache/pulsar/pull/16363#issuecomment-1192258576

   LGTM. Interesting patch and the movement :)
   
   I like linters to help the codebase style consistent and this plugin additionally avoid continue using deprecated methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org