You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "entvex (via GitHub)" <gi...@apache.org> on 2023/05/27 12:01:55 UTC

[GitHub] [pulsar-dotpulsar] entvex opened a new pull request, #157: Moved docfx away from the root

entvex opened a new pull request, #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157

   This commit relates to Issue #153
   
   # Description
   I have moved the docfx files away from the folder root and into the folder docfx_project


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] entvex commented on pull request #157: Moved docfx away from the root

Posted by "entvex (via GitHub)" <gi...@apache.org>.
entvex commented on PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#issuecomment-1565449102

   > Tests fails with timeout. But we don't touch any related code. I notice that the master branch fails after merging #155.
   > 
   > Unblocking this PR...
   
   Yeah, sometimes the tests are flaky.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] tisonkun merged pull request #157: Moved docfx away from the root

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] entvex commented on pull request #157: Moved docfx away from the root

Posted by "entvex (via GitHub)" <gi...@apache.org>.
entvex commented on PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#issuecomment-1565418016

   Thanks @tisonkun 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] tisonkun commented on a diff in pull request #157: Moved docfx away from the root

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#discussion_r1207942349


##########
docfx_project/index.md:
##########
@@ -0,0 +1 @@
+README.md

Review Comment:
   Let me try to add a new homepage to avoid such links.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] tisonkun commented on pull request #157: Moved docfx away from the root

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#issuecomment-1565414829

   I pushed two more commit based on this branch to make things work correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] tisonkun commented on pull request #157: Moved docfx away from the root

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#issuecomment-1565442812

   Tests fails with timeout. But we don't touch any related code. I notice that the master branch fails after merging https://github.com/apache/pulsar-dotpulsar/pull/155.
   
   Unblocking this PR...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-dotpulsar] tisonkun commented on a diff in pull request #157: Moved docfx away from the root

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #157:
URL: https://github.com/apache/pulsar-dotpulsar/pull/157#discussion_r1207941555


##########
docfx_project/index.md:
##########
@@ -0,0 +1 @@
+README.md

Review Comment:
   Symbol link cannot work now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org