You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <HT...@schubergphilis.com> on 2013/02/15 18:11:24 UTC
RE: git commit: refs/heads/master - added db.properties to usage
test resources
Hey Kishan,
This is probably not going to work. This only works if you have an actual database, we need the test to run without a database by mocking all DAOs
Nice work on the tests by the way!
Hugo
> -----Original Message-----
> From: kishan@apache.org [mailto:kishan@apache.org]
> Sent: Friday, February 15, 2013 6:09 PM
> To: cloudstack-commits@incubator.apache.org
> Subject: git commit: refs/heads/master - added db.properties to usage test
> resources
>
> Updated Branches:
> refs/heads/master 2beb66fd3 -> b54db07d2
>
>
> added db.properties to usage test resources
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/commit/b54db07d
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/tree/b54db07d
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/diff/b54db07d
>
> Branch: refs/heads/master
> Commit: b54db07d20893a437bb327f08d891553aa98aef8
> Parents: 2beb66f
> Author: Kishan Kavala <ki...@cloud.com>
> Authored: Fri Feb 15 22:35:45 2013 +0530
> Committer: Kishan Kavala <ki...@cloud.com>
> Committed: Fri Feb 15 22:39:04 2013 +0530
>
> ----------------------------------------------------------------------
> usage/test/resources/db.properties | 70
> +++++++++++++++++++++++++++++++
> 1 files changed, 70 insertions(+), 0 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-
> cloudstack/blob/b54db07d/usage/test/resources/db.properties
> ----------------------------------------------------------------------
> diff --git a/usage/test/resources/db.properties
> b/usage/test/resources/db.properties
> new file mode 100644
> index 0000000..18bf54c
> --- /dev/null
> +++ b/usage/test/resources/db.properties
> @@ -0,0 +1,70 @@
> +# Licensed to the Apache Software Foundation (ASF) under one # or more
> +contributor license agreements. See the NOTICE file # distributed with
> +this work for additional information # regarding copyright ownership.
> +The ASF licenses this file # to you under the Apache License, Version
> +2.0 (the # "License"); you may not use this file except in compliance #
> +with the License. You may obtain a copy of the License at #
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing, # software
> +distributed under the License is distributed on an # "AS IS" BASIS,
> +WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or
> +implied. See the License for the # specific language governing
> +permissions and limitations # under the License.
> +
> +
> +# management server clustering parameters, change cluster.node.IP to
> +the machine IP address # in which the management server(Tomcat) is
> +running
> +cluster.node.IP=127.0.0.1
> +cluster.servlet.port=9090
> +
> +# CloudStack database settings
> +db.cloud.username=cloud
> +db.cloud.password=cloud
> +db.root.password=
> +db.cloud.host=localhost
> +db.cloud.port=3306
> +db.cloud.name=cloud
> +
> +# CloudStack database tuning parameters
> +db.cloud.maxActive=250
> +db.cloud.maxIdle=30
> +db.cloud.maxWait=10000
> +db.cloud.autoReconnect=true
> +db.cloud.validationQuery=SELECT 1
> +db.cloud.testOnBorrow=true
> +db.cloud.testWhileIdle=true
> +db.cloud.timeBetweenEvictionRunsMillis=40000
> +db.cloud.minEvictableIdleTimeMillis=240000
> +db.cloud.poolPreparedStatements=false
> +db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prep
> StmtC
> +acheSqlLimit=4096
> +
> +# usage database settings
> +db.usage.username=cloud
> +db.usage.password=cloud
> +db.usage.host=localhost
> +db.usage.port=3306
> +db.usage.name=cloud_usage
> +
> +# usage database tuning parameters
> +db.usage.maxActive=100
> +db.usage.maxIdle=30
> +db.usage.maxWait=10000
> +db.usage.autoReconnect=true
> +
> +# awsapi database settings
> +db.awsapi.name=cloudbridge
> +
> +# Simulator database settings
> +db.simulator.username=cloud
> +db.simulator.password=cloud
> +db.simulator.host=localhost
> +db.simulator.port=3306
> +db.simulator.name=simulator
> +db.simulator.maxActive=250
> +db.simulator.maxIdle=30
> +db.simulator.maxWait=10000
> +db.simulator.autoReconnect=true
RE: git commit: refs/heads/master - added db.properties to usage
test resources
Posted by Kishan Kavala <Ki...@citrix.com>.
Thanks Hugo and Rohit.
I've excluded this test in pom.xml for now (similar to SecurityGroupManagerImpl2Test). I'll enable the test after mocking the DAOs.
> -----Original Message-----
> From: rohityadav89@gmail.com [mailto:rohityadav89@gmail.com] On Behalf
> Of Rohit Yadav
> Sent: Saturday, 16 February 2013 12:15 PM
> To: cloudstack-dev@incubator.apache.org
> Cc: kishan@apache.org
> Subject: Re: git commit: refs/heads/master - added db.properties to usage
> test resources
>
> On Fri, Feb 15, 2013 at 10:41 PM, Hugo Trippaers
> <HT...@schubergphilis.com> wrote:
> > Hey Kishan,
> >
> > This is probably not going to work. This only works if you have an
> > actual database, we need the test to run without a database by mocking
> > all DAOs
>
> Kishan, I can help you with that, monday or today?
>
> Regards.
>
> >
> > Nice work on the tests by the way!
> >
> > Hugo
> >
> >> -----Original Message-----
> >> From: kishan@apache.org [mailto:kishan@apache.org]
> >> Sent: Friday, February 15, 2013 6:09 PM
> >> To: cloudstack-commits@incubator.apache.org
> >> Subject: git commit: refs/heads/master - added db.properties to usage
> >> test resources
> >>
> >> Updated Branches:
> >> refs/heads/master 2beb66fd3 -> b54db07d2
> >>
> >>
> >> added db.properties to usage test resources
> >>
> >>
> >> Project:
> >> http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/incubator-
> >> cloudstack/commit/b54db07d
> >> Tree: http://git-wip-us.apache.org/repos/asf/incubator-
> >> cloudstack/tree/b54db07d
> >> Diff: http://git-wip-us.apache.org/repos/asf/incubator-
> >> cloudstack/diff/b54db07d
> >>
> >> Branch: refs/heads/master
> >> Commit: b54db07d20893a437bb327f08d891553aa98aef8
> >> Parents: 2beb66f
> >> Author: Kishan Kavala <ki...@cloud.com>
> >> Authored: Fri Feb 15 22:35:45 2013 +0530
> >> Committer: Kishan Kavala <ki...@cloud.com>
> >> Committed: Fri Feb 15 22:39:04 2013 +0530
> >>
> >> ----------------------------------------------------------------------
> >> usage/test/resources/db.properties | 70
> >> +++++++++++++++++++++++++++++++
> >> 1 files changed, 70 insertions(+), 0 deletions(-)
> >> ---------------------------------------------------------------------
> >> -
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/incubator-
> >> cloudstack/blob/b54db07d/usage/test/resources/db.properties
> >> ---------------------------------------------------------------------
> >> - diff --git a/usage/test/resources/db.properties
> >> b/usage/test/resources/db.properties
> >> new file mode 100644
> >> index 0000000..18bf54c
> >> --- /dev/null
> >> +++ b/usage/test/resources/db.properties
> >> @@ -0,0 +1,70 @@
> >> +# Licensed to the Apache Software Foundation (ASF) under one # or
> >> +more contributor license agreements. See the NOTICE file #
> >> +distributed with this work for additional information # regarding
> copyright ownership.
> >> +The ASF licenses this file # to you under the Apache License,
> >> +Version
> >> +2.0 (the # "License"); you may not use this file except in
> >> +compliance # with the License. You may obtain a copy of the License at #
> >> +# http://www.apache.org/licenses/LICENSE-2.0
> >> +#
> >> +# Unless required by applicable law or agreed to in writing, #
> >> +software distributed under the License is distributed on an # "AS
> >> +IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND,
> either
> >> +express or implied. See the License for the # specific language
> >> +governing permissions and limitations # under the License.
> >> +
> >> +
> >> +# management server clustering parameters, change cluster.node.IP to
> >> +the machine IP address # in which the management server(Tomcat) is
> >> +running
> >> +cluster.node.IP=127.0.0.1
> >> +cluster.servlet.port=9090
> >> +
> >> +# CloudStack database settings
> >> +db.cloud.username=cloud
> >> +db.cloud.password=cloud
> >> +db.root.password=
> >> +db.cloud.host=localhost
> >> +db.cloud.port=3306
> >> +db.cloud.name=cloud
> >> +
> >> +# CloudStack database tuning parameters
> >> +db.cloud.maxActive=250
> >> +db.cloud.maxIdle=30
> >> +db.cloud.maxWait=10000
> >> +db.cloud.autoReconnect=true
> >> +db.cloud.validationQuery=SELECT 1
> >> +db.cloud.testOnBorrow=true
> >> +db.cloud.testWhileIdle=true
> >> +db.cloud.timeBetweenEvictionRunsMillis=40000
> >> +db.cloud.minEvictableIdleTimeMillis=240000
> >> +db.cloud.poolPreparedStatements=false
> >>
> +db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prep
> >> StmtC
> >> +acheSqlLimit=4096
> >> +
> >> +# usage database settings
> >> +db.usage.username=cloud
> >> +db.usage.password=cloud
> >> +db.usage.host=localhost
> >> +db.usage.port=3306
> >> +db.usage.name=cloud_usage
> >> +
> >> +# usage database tuning parameters
> >> +db.usage.maxActive=100
> >> +db.usage.maxIdle=30
> >> +db.usage.maxWait=10000
> >> +db.usage.autoReconnect=true
> >> +
> >> +# awsapi database settings
> >> +db.awsapi.name=cloudbridge
> >> +
> >> +# Simulator database settings
> >> +db.simulator.username=cloud
> >> +db.simulator.password=cloud
> >> +db.simulator.host=localhost
> >> +db.simulator.port=3306
> >> +db.simulator.name=simulator
> >> +db.simulator.maxActive=250
> >> +db.simulator.maxIdle=30
> >> +db.simulator.maxWait=10000
> >> +db.simulator.autoReconnect=true
> >
Re: git commit: refs/heads/master - added db.properties to usage test resources
Posted by Rohit Yadav <bh...@apache.org>.
On Fri, Feb 15, 2013 at 10:41 PM, Hugo Trippaers
<HT...@schubergphilis.com> wrote:
> Hey Kishan,
>
> This is probably not going to work. This only works if you have an actual database, we need the test to run without a database by mocking all DAOs
Kishan, I can help you with that, monday or today?
Regards.
>
> Nice work on the tests by the way!
>
> Hugo
>
>> -----Original Message-----
>> From: kishan@apache.org [mailto:kishan@apache.org]
>> Sent: Friday, February 15, 2013 6:09 PM
>> To: cloudstack-commits@incubator.apache.org
>> Subject: git commit: refs/heads/master - added db.properties to usage test
>> resources
>>
>> Updated Branches:
>> refs/heads/master 2beb66fd3 -> b54db07d2
>>
>>
>> added db.properties to usage test resources
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/incubator-
>> cloudstack/commit/b54db07d
>> Tree: http://git-wip-us.apache.org/repos/asf/incubator-
>> cloudstack/tree/b54db07d
>> Diff: http://git-wip-us.apache.org/repos/asf/incubator-
>> cloudstack/diff/b54db07d
>>
>> Branch: refs/heads/master
>> Commit: b54db07d20893a437bb327f08d891553aa98aef8
>> Parents: 2beb66f
>> Author: Kishan Kavala <ki...@cloud.com>
>> Authored: Fri Feb 15 22:35:45 2013 +0530
>> Committer: Kishan Kavala <ki...@cloud.com>
>> Committed: Fri Feb 15 22:39:04 2013 +0530
>>
>> ----------------------------------------------------------------------
>> usage/test/resources/db.properties | 70
>> +++++++++++++++++++++++++++++++
>> 1 files changed, 70 insertions(+), 0 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-
>> cloudstack/blob/b54db07d/usage/test/resources/db.properties
>> ----------------------------------------------------------------------
>> diff --git a/usage/test/resources/db.properties
>> b/usage/test/resources/db.properties
>> new file mode 100644
>> index 0000000..18bf54c
>> --- /dev/null
>> +++ b/usage/test/resources/db.properties
>> @@ -0,0 +1,70 @@
>> +# Licensed to the Apache Software Foundation (ASF) under one # or more
>> +contributor license agreements. See the NOTICE file # distributed with
>> +this work for additional information # regarding copyright ownership.
>> +The ASF licenses this file # to you under the Apache License, Version
>> +2.0 (the # "License"); you may not use this file except in compliance #
>> +with the License. You may obtain a copy of the License at #
>> +# http://www.apache.org/licenses/LICENSE-2.0
>> +#
>> +# Unless required by applicable law or agreed to in writing, # software
>> +distributed under the License is distributed on an # "AS IS" BASIS,
>> +WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or
>> +implied. See the License for the # specific language governing
>> +permissions and limitations # under the License.
>> +
>> +
>> +# management server clustering parameters, change cluster.node.IP to
>> +the machine IP address # in which the management server(Tomcat) is
>> +running
>> +cluster.node.IP=127.0.0.1
>> +cluster.servlet.port=9090
>> +
>> +# CloudStack database settings
>> +db.cloud.username=cloud
>> +db.cloud.password=cloud
>> +db.root.password=
>> +db.cloud.host=localhost
>> +db.cloud.port=3306
>> +db.cloud.name=cloud
>> +
>> +# CloudStack database tuning parameters
>> +db.cloud.maxActive=250
>> +db.cloud.maxIdle=30
>> +db.cloud.maxWait=10000
>> +db.cloud.autoReconnect=true
>> +db.cloud.validationQuery=SELECT 1
>> +db.cloud.testOnBorrow=true
>> +db.cloud.testWhileIdle=true
>> +db.cloud.timeBetweenEvictionRunsMillis=40000
>> +db.cloud.minEvictableIdleTimeMillis=240000
>> +db.cloud.poolPreparedStatements=false
>> +db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prep
>> StmtC
>> +acheSqlLimit=4096
>> +
>> +# usage database settings
>> +db.usage.username=cloud
>> +db.usage.password=cloud
>> +db.usage.host=localhost
>> +db.usage.port=3306
>> +db.usage.name=cloud_usage
>> +
>> +# usage database tuning parameters
>> +db.usage.maxActive=100
>> +db.usage.maxIdle=30
>> +db.usage.maxWait=10000
>> +db.usage.autoReconnect=true
>> +
>> +# awsapi database settings
>> +db.awsapi.name=cloudbridge
>> +
>> +# Simulator database settings
>> +db.simulator.username=cloud
>> +db.simulator.password=cloud
>> +db.simulator.host=localhost
>> +db.simulator.port=3306
>> +db.simulator.name=simulator
>> +db.simulator.maxActive=250
>> +db.simulator.maxIdle=30
>> +db.simulator.maxWait=10000
>> +db.simulator.autoReconnect=true
>