Re: [PR] [FLINK-39368][connector-http] Add User-Agent configuration support for HTTP sink and lookup [flink-connector-http]

["davidradl (via GitHub)" <gi...@apache.org>]

davidradl commented on code in PR #34:
URL: https://github.com/apache/flink-connector-http/pull/34#discussion_r3115902465


##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/HttpDynamicSinkConnectorOptions.java:
##########
@@ -41,4 +41,12 @@ public class HttpDynamicSinkConnectorOptions {
             ConfigOptions.key(SINK_REQUEST_CALLBACK_IDENTIFIER)
                     .stringType()
                     .defaultValue(Slf4jHttpPostRequestCallbackFactory.IDENTIFIER);
+
+    public static final ConfigOption<String> USER_AGENT =
+            ConfigOptions.key("http.user.agent")
+                    .stringType()
+                    .defaultValue("flink-http-connector")
+                    .withDescription(
+                            "The User-Agent header value for HTTP sink requests. "
+                                    + "Default value is 'flink-http-connector'.");

Review Comment:
   maybe default to `flink-connector-http`. `flink-http-connector i`s the getindata identifier for the HTTP connector we moved from.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org