You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/05 09:49:59 UTC

[GitHub] spark pull request #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time...

GitHub user gengliangwang opened a pull request:

    https://github.com/apache/spark/pull/22640

    [SPARK-25621][SPARK-25622][TEST] Reduce test time of BucketedReadWithHiveSupportSuite

    ## What changes were proposed in this pull request?
    
    By reduce the number of loops.
    - `read partitioning bucketed tables with bucket pruning filters` reduce from 55s to 14s
    - `read partitioning bucketed tables having composite filters` reduce from 54s to 11s
    - total time: reduce from 288s to 192s
    
    ## How was this patch tested?
    
    Unit test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gengliangwang/spark fastenBucketedReadSuite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22640
    
----
commit 58c419a3298425a3228020a9a6ee13fb4451557e
Author: Gengliang Wang <ge...@...>
Date:   2018-10-05T09:33:51Z

    fasten BucketedReadSuite

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96988/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    **[Test build #96988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96988/testReport)** for PR 22640 at commit [`58c419a`](https://github.com/apache/spark/commit/58c419a3298425a3228020a9a6ee13fb4451557e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    **[Test build #97004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97004/testReport)** for PR 22640 at commit [`1c5bfef`](https://github.com/apache/spark/commit/1c5bfef591932a281a2c91b035dfb0a482ed4e7a).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    **[Test build #96988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96988/testReport)** for PR 22640 at commit [`58c419a`](https://github.com/apache/spark/commit/58c419a3298425a3228020a9a6ee13fb4451557e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22640#discussion_r222975187
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
    @@ -66,7 +66,7 @@ abstract class BucketedReadSuite extends QueryTest with SQLTestUtils {
             .bucketBy(8, "j", "k")
             .saveAsTable("bucketed_table")
     
    -      for (i <- 0 until 5) {
    --- End diff --
    
    Oh haha I was struggling why it was 5 and 13 and looks it's in `df` :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97004/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    cc @cloud-fan too for sure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3721/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3710/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22640


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    **[Test build #97004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97004/testReport)** for PR 22640 at commit [`1c5bfef`](https://github.com/apache/spark/commit/1c5bfef591932a281a2c91b035dfb0a482ed4e7a).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22640: [SPARK-25621][SPARK-25622][TEST] Reduce test time of Buc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22640
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org