You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/20 11:55:32 UTC

[GitHub] ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for convolution.

ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-448973617
 
 
   @marcoabreu Looks like CI has trouble to build this PR. Some builds failed to compile this line
   https://github.com/apache/incubator-mxnet/blob/84131807d67bb6a256b78cd75bb12a274c22347b/include/mxnet/tensor_blob.h#L290
   with `comparison between signed and unsigned integer expressions`. But this PR doesn't touch that part, and looking into the code, both sides are returning size_t, which should be all same. Another prove is, clang can build pass with `-Wsign-compare`, which indicated that the gcc build has some problem. Can you have a look? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services