You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/08/06 07:57:41 UTC

Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
    https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
-------

Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.


Diffs
-----

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 3c925bcb2250ea7aea26443c866ac4bfd26d55b9 


Diff: https://reviews.apache.org/r/68213/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/#review207058
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Aug. 7, 2018, 7:11 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68213/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 7:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
>     https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 3c925bcb2250ea7aea26443c866ac4bfd26d55b9 
> 
> 
> Diff: https://reviews.apache.org/r/68213/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/
-----------------------------------------------------------

(Updated Aug. 7, 2018, 10:11 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-8814
    https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
-------

Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.


Diffs (updated)
-----

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 3c925bcb2250ea7aea26443c866ac4bfd26d55b9 


Diff: https://reviews.apache.org/r/68213/diff/2/

Changes: https://reviews.apache.org/r/68213/diff/1-2/


Testing
-------

sudo make check


Thanks,

Qian Zhang