[GitHub] [sling-org-apache-sling-committer-cli] raducotescu commented on a diff in pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

[GitBox <gi...@apache.org>]

raducotescu commented on code in PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#discussion_r911374155


##########
Dockerfile:
##########
@@ -9,7 +9,8 @@
 # either express or implied. See the License for the specific language governing permissions
 # and limitations under the License.
 # ----------------------------------------------------------------------------------------
-FROM eclipse-temurin:11-alpine as builder
+FROM azul/zulu-openjdk-alpine:17 as builder
+RUN apk add --no-cache binutils

Review Comment:
   `--strip-debug` requires `objcopy` starting with JDK 13 - https://github.com/docker-library/openjdk/issues/351.
   
   We can either add `binutils` in this builder layer and continue using `--strip-debug`, or switch to `--strip-java-debug-attributes`, which nowadays does what `--strip-debug` used to do in JDK 11. See https://bugs.openjdk.org/browse/JDK-8219207 for more details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org