You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2016/05/16 10:40:49 UTC
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/13134
[SPARK-15342][SQL][PySpark] PySpark test for non ascii column name does not actually test with unicode column name
## What changes were proposed in this pull request?
The PySpark SQL `test_column_name_with_non_ascii` wants to test non-ascii column name. But it doesn't actually test it. We need to construct an unicode explicitly using `unicode` under Python 2.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 correct-non-ascii-colname-pytest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13134
----
commit 5f5df821fa91049b4ae0b16062483c1512f7d3e5
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Date: 2016-05-16T10:07:15Z
Make the test really test non-ascii column name.
commit 494aee2857966359d4211c6bc6d403bf4ccff6f3
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Date: 2016-05-16T10:23:42Z
Test if column name is unicode.
commit b5abe422e3e9eb40094e0a955ee4aa2d8280a7f5
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Date: 2016-05-16T10:40:22Z
Consider both python 2 and 3.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-220113628
LGTM,
Merging this into master and 2.0, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219620469
**[Test build #58665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58665/consoleFull)** for PR 13134 at commit [`97fb7f5`](https://github.com/apache/spark/commit/97fb7f555cffc96f140e483c455e366265de5459).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219397471
**[Test build #58637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58637/consoleFull)** for PR 13134 at commit [`b5abe42`](https://github.com/apache/spark/commit/b5abe422e3e9eb40094e0a955ee4aa2d8280a7f5).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219399948
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219399871
**[Test build #58637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58637/consoleFull)** for PR 13134 at commit [`b5abe42`](https://github.com/apache/spark/commit/b5abe422e3e9eb40094e0a955ee4aa2d8280a7f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219620522
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58665/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219399952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58637/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219618868
**[Test build #58665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58665/consoleFull)** for PR 13134 at commit [`97fb7f5`](https://github.com/apache/spark/commit/97fb7f555cffc96f140e483c455e366265de5459).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219620521
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13134#discussion_r63345939
--- Diff: python/pyspark/sql/tests.py ---
@@ -1036,8 +1036,15 @@ def test_access_column(self):
self.assertRaises(TypeError, lambda: df[{}])
def test_column_name_with_non_ascii(self):
- df = self.spark.createDataFrame([(1,)], ["数量"])
- self.assertEqual(StructType([StructField("数量", LongType(), True)]), df.schema)
+ if sys.version >= '3':
--- End diff --
Is this the only place we use unicode() in pyspark? this otherwise looks like something that might need to be applied to other tests that try something similar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13134#discussion_r63464031
--- Diff: python/pyspark/sql/tests.py ---
@@ -1036,8 +1036,15 @@ def test_access_column(self):
self.assertRaises(TypeError, lambda: df[{}])
def test_column_name_with_non_ascii(self):
- df = self.spark.createDataFrame([(1,)], ["数量"])
- self.assertEqual(StructType([StructField("数量", LongType(), True)]), df.schema)
+ if sys.version >= '3':
--- End diff --
The usage in other places looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15342][SQL][PySpark] PySpark test for n...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/13134#issuecomment-219914749
cc @davies Please take a look, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org