You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/04 02:24:26 UTC

[GitHub] [rocketmq-mqtt] DongyuanPan opened a new pull request, #134: bug fix: change groupId

DongyuanPan opened a new pull request, #134:
URL: https://github.com/apache/rocketmq-mqtt/pull/134

   groupID should be started with character 'a'-'z' or 'A'-'Z', and followed with numbers, english alphabet, '-' or '_'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-mqtt] pingww merged pull request #134: bug fix: change groupId

Posted by GitBox <gi...@apache.org>.
pingww merged PR #134:
URL: https://github.com/apache/rocketmq-mqtt/pull/134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #134: bug fix: change groupId

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #134:
URL: https://github.com/apache/rocketmq-mqtt/pull/134#issuecomment-1204828715

   # [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/134?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#134](https://codecov.io/gh/apache/rocketmq-mqtt/pull/134?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (861ecf2) into [develop](https://codecov.io/gh/apache/rocketmq-mqtt/commit/af50ca0462dc92136816a83fbb51a477b3535f15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af50ca0) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #134   +/-   ##
   ========================================
     Coverage    41.95%   41.95%           
   ========================================
     Files          118      118           
     Lines         4900     4900           
     Branches       713      713           
   ========================================
     Hits          2056     2056           
     Misses        2490     2490           
     Partials       354      354           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/rocketmq/mqtt/meta/raft/MqttRaftServer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9tZXRhL3JhZnQvTXF0dFJhZnRTZXJ2ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #134: bug fix: change groupId

Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #134:
URL: https://github.com/apache/rocketmq-mqtt/pull/134#issuecomment-1204682733

   #133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org