[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10165: fix: downgrade sqlparse and add unit test

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10165:
URL: https://github.com/apache/incubator-superset/pull/10165#discussion_r446290160



##########
File path: tests/sql_parse_tests.py
##########
@@ -187,7 +189,8 @@ def test_select_if(self):
     # SHOW TABLES ((FROM | IN) qualifiedName)? (LIKE pattern=STRING)?
     def test_show_tables(self):
         query = "SHOW TABLES FROM s1 like '%order%'"
-        self.assertEqual(set(), self.extract_tables(query))
+        # TODO: figure out what should code do here

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org