[GitHub] [superset] kgabryje commented on pull request #12384: fix: Temporarily disable editing metric title

[GitBox <gi...@apache.org>]

kgabryje commented on pull request #12384:
URL: https://github.com/apache/superset/pull/12384#issuecomment-757899615


   @ktmud This PR disables edits for every metric as I misunderstood the requirement. Disabling edits just for saved metrics would require some more refactoring and we decided that we should wait for the overrides feature instead of introducing changes that would soon need a revert. However, if you think it's vital to disable edits for saved metrics until the feature is implemented, I could take it on again


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org