You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2018/03/19 11:40:29 UTC
[GitHub] zeppelin pull request #2881: ZEPPELIN-3313 z.getInterpreterContext().out().c...
GitHub user r-kamath opened a pull request:
https://github.com/apache/zeppelin/pull/2881
ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data
### What is this PR for?
z.getInterpreterContext().out().clear() fails to clear table data
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3313](https://issues.apache.org/jira/browse/ZEPPELIN-3313)
### How should this be tested?
see jira description
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-3313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2881.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2881
----
commit d67974e2bd42e668a95cb3ac053eaf0336d1e81b
Author: Renjith Kamath <re...@...>
Date: 2018-03-19T11:34:12Z
ZEPPELIN-3313 z.getInterpreterContext().out().clear() fails to clear table data
----
---
[GitHub] zeppelin pull request #2881: ZEPPELIN-3313 z.getInterpreterContext().out().c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2881
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2881
Thanks @r-kamath , I try another example, but the result seems unstable (sometimes it would display 2 elements), see screenshot.
Another issue is that if I select another chart type, the result would be even more unstable.
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2881
> @zjffdu the issue in the second screenshot will not occur when viz switching is enabled, I'm working on it
Patch will be send in a different PR.
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2881
@zjffdu the issue in the second screenshot will not occur when viz switching is enabled, I'm working on it
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2881
will merge this if there are no more discussions
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2881
LGTM
---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2881
@zjffdu currently data update and refresh timing in ui grid is not guaranteed. This issue persists only when the interval is below 1sec. I modified your example with 2sec delay and the rendering is fine.
However, frequent refreshing of ui table is causing too many
`[Violation] 'setTimeout' handler took <N>ms` and
`[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>`
About support for Passive Event Listeners: https://stackoverflow.com/a/39187679
---