[GitHub] liupc commented on a change in pull request #23438: [SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of the iteration

[GitBox <gi...@apache.org>]

liupc commented on a change in pull request #23438: [SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of the iteration
URL: https://github.com/apache/spark/pull/23438#discussion_r252916838
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
 ##########
 @@ -509,6 +511,11 @@ final class ShuffleBlockFetcherIterator(
     (currentResult.blockId, new BufferReleasingInputStream(input, this))
   }
 
+  def toCompletionIterator: Iterator[(BlockId, InputStream)] = {
+    CompletionIterator[(BlockId, InputStream), this.type](this,
 
 Review comment:
   @viirya 
   It will be released early in `CoalecedRDD`, for it's just one of the iterators for `CoalescedRDDPartition`, once it's exhausted, there are no objects will refer to it, so it can be released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org