You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2021/07/22 12:56:22 UTC

[GitHub] [felix-dev] amitjoy commented on a change in pull request #81: Introduced thread-safety while updating field during deactivation phase

amitjoy commented on a change in pull request #81:
URL: https://github.com/apache/felix-dev/pull/81#discussion_r674770047



##########
File path: scr/src/main/java/org/apache/felix/scr/impl/inject/field/FieldHandler.java
##########
@@ -171,9 +171,9 @@ private boolean initField(final Object componentInstance,
         return objects;
     }
 
-    private MethodResult updateField(final METHOD_TYPE mType,
-                                     final Object componentInstance,
-                                     final BindParameters bp)
+    private synchronized MethodResult updateField(final METHOD_TYPE mType,

Review comment:
       Applied your proposal




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org