You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/03/22 17:46:56 UTC

[PR] fix: replace #3311 references with specific issues in 3.5.8 diff [datafusion-comet]

andygrove opened a new pull request, #3761:
URL: https://github.com/apache/datafusion-comet/pull/3761

   ## Which issue does this PR close?
   
   Partial close of #3311 — replaces all references to #3311 in the 3.5.8 Spark SQL test diff with more specific issues.
   
   ## Rationale for this change
   
   Issue #3311 is a broad tracking issue covering multiple distinct problems. Replacing references with specific issues makes it easier to track and resolve individual problems, and will allow #3311 to be closed.
   
   ## What changes are included in this PR?
   
   Updates the 3.5.8 diff to replace `IgnoreCometNativeDataFusion` references from #3311 to:
   
   - **caseSensitive** (`FileBasedDataSourceSuite`) → #3760 (case-insensitive duplicate field detection)
   - **SPARK-34212 Parquet should read decimals correctly** (`ParquetQuerySuite`) → #3720 (schema mismatch no error)
   - **schema mismatch failure error message** (`ParquetSchemaSuite`) → #3720
   - **SPARK-45604 timestamp_ntz to array** (`ParquetSchemaSuite`) → #3720
   
   ## How are these changes tested?
   
   Diff applies cleanly to Spark v3.5.8. CI will validate via the Spark SQL test workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: replace #3311 references with specific issues in 3.5.8 diff [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #3761:
URL: https://github.com/apache/datafusion-comet/pull/3761#discussion_r2971840898


##########
dev/diffs/3.5.8.diff:
##########
@@ -979,6 +980,37 @@ index 3cf2bfd17ab..49728c35c42 100644
      withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false",
        SQLConf.ANSI_ENABLED.key -> "true") {
        withTable("t") {
+diff --git a/sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
+index 8b4ac474f87..3f79f20822f 100644
+--- a/sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala

Review Comment:
   the old diff did not list all files in correct alphabetical order. This just moved a section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: [native_datafusion] replace #3311 references with specific issues in 3.5.8 diff [datafusion-comet]

Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #3761:
URL: https://github.com/apache/datafusion-comet/pull/3761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org