You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <sk...@twitter.com> on 2013/12/10 21:48:31 UTC
Review Request 16163: Added extra_modules option to Scheduler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
Added extra_modules option to Scheduler.
Already have ship it on this in the internal repo. Sending it for review again to check it in.
Diffs
-----
src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d
Diff: https://reviews.apache.org/r/16163/diff/
Testing
-------
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16163: Added extra_modules option to Scheduler.
Posted by Suman Karumuri <sk...@twitter.com>.
> On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote:
> > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java, line 141
> > <https://reviews.apache.org/r/16163/diff/1/?file=396257#file396257line141>
> >
> > please drop QUOTA from here, as i'm pulling that out in a separate review
I was planning to merge later, but since I have to move repos anyways, did it now. Done.
> On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote:
> > src/main/java/com/twitter/aurora/scheduler/app/Modules.java, line 1
> > <https://reviews.apache.org/r/16163/diff/1/?file=396256#file396256line1>
> >
> > please add license header. i suggest you go ahead and configure intellij to fill it in for you (search for 'template' in the preferences search bar).
Done. Thanks.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/#review30169
-----------------------------------------------------------
On Dec. 10, 2013, 8:48 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16163/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 8:48 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added extra_modules option to Scheduler.
>
> Already have ship it on this in the internal repo. Sending it for review again to check it in.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
> src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d
>
> Diff: https://reviews.apache.org/r/16163/diff/
>
>
> Testing
> -------
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16163: Added extra_modules option to Scheduler.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/#review30169
-----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/app/Modules.java
<https://reviews.apache.org/r/16163/#comment57749>
please add license header. i suggest you go ahead and configure intellij to fill it in for you (search for 'template' in the preferences search bar).
src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java
<https://reviews.apache.org/r/16163/#comment57750>
please drop QUOTA from here, as i'm pulling that out in a separate review
- Bill Farner
On Dec. 10, 2013, 8:48 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16163/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 8:48 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added extra_modules option to Scheduler.
>
> Already have ship it on this in the internal repo. Sending it for review again to check it in.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
> src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d
>
> Diff: https://reviews.apache.org/r/16163/diff/
>
>
> Testing
> -------
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16163: Added extra_modules option to Scheduler.
Posted by Suman Karumuri <su...@gmail.com>.
> On Dec. 14, 2013, 2:03 a.m., Bill Farner wrote:
> > Ship It!
Thanks!
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/#review30401
-----------------------------------------------------------
On Dec. 13, 2013, 10:23 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16163/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 10:23 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added extra_modules option to Scheduler.
>
> Already have ship it on this in the internal repo. Sending it for review again to check it in.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
> src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java ec99e01dd4f982ed5b794ff86b65e6f58d2a0e27
>
> Diff: https://reviews.apache.org/r/16163/diff/
>
>
> Testing
> -------
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16163: Added extra_modules option to Scheduler.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/#review30401
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Dec. 13, 2013, 10:23 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16163/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 10:23 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added extra_modules option to Scheduler.
>
> Already have ship it on this in the internal repo. Sending it for review again to check it in.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
> src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java ec99e01dd4f982ed5b794ff86b65e6f58d2a0e27
>
> Diff: https://reviews.apache.org/r/16163/diff/
>
>
> Testing
> -------
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16163: Added extra_modules option to Scheduler.
Posted by Suman Karumuri <sk...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16163/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 10:23 p.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
Removed quota module. Added license.
Repository: aurora
Description
-------
Added extra_modules option to Scheduler.
Already have ship it on this in the internal repo. Sending it for review again to check it in.
Diffs (updated)
-----
src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION
src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java ec99e01dd4f982ed5b794ff86b65e6f58d2a0e27
Diff: https://reviews.apache.org/r/16163/diff/
Testing
-------
gradle clean build.
Thanks,
Suman Karumuri