[GitHub] [mina-ftpserver] elecharny commented on pull request #17: Simplify conditions and avoid extra compute.

[GitBox <gi...@apache.org>]

elecharny commented on PR #17:
URL: https://github.com/apache/mina-ftpserver/pull/17#issuecomment-1087765913

   Hi Arturo, 
   
   for the OPTS_MLST patch, I think the logic would be to check if the returned array is not empty, and if so returning an error. The current code check if it's NULL but I think it's a mistake. So your suggestion is correct (logically) but I'd rather change the 'if' and keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org