You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/07 16:34:44 UTC
[GitHub] [cordova-plugin-wkwebview-engine] breautek opened a new pull request #186: docs: Deprecation notice
breautek opened a new pull request #186:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/186
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on a change in pull request #186: docs: Deprecation notice
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #186:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/186#discussion_r572039417
##########
File path: README.md
##########
@@ -28,6 +28,12 @@ This plugin makes `Cordova` use the `WKWebView` component instead of the default
In iOS 9, Apple has fixed the [issue](http://www.openradar.me/18039024) present through iOS 8 where you cannot load locale files using file://, and must resort to using a local webserver. **However, you are still not able to use XHR from the file:// protocol without [CORS](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS) enabled on your server.**
+### Deprecation Notice
+
+This plugin is now deprecated as it's implementation has been moved to `cordova-ios` platform making this plugin redundent. When migrating to `cordova-ios@6`, you should remove this plugin.
+
+This plugin should still work as is on `cordova-ios@5.1.1` for the foreseeable future, however it is recommended to remove this plugin and upgrade to `cordova-ios@6`.
+
Review comment:
I'll add `or later` text. Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] NiklasMerz commented on a change in pull request #186: docs: Deprecation notice
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #186:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/186#discussion_r572038134
##########
File path: README.md
##########
@@ -28,6 +28,12 @@ This plugin makes `Cordova` use the `WKWebView` component instead of the default
In iOS 9, Apple has fixed the [issue](http://www.openradar.me/18039024) present through iOS 8 where you cannot load locale files using file://, and must resort to using a local webserver. **However, you are still not able to use XHR from the file:// protocol without [CORS](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS) enabled on your server.**
+### Deprecation Notice
+
+This plugin is now deprecated as it's implementation has been moved to `cordova-ios` platform making this plugin redundent. When migrating to `cordova-ios@6`, you should remove this plugin.
+
+This plugin should still work as is on `cordova-ios@5.1.1` for the foreseeable future, however it is recommended to remove this plugin and upgrade to `cordova-ios@6`.
+
Review comment:
Should we say something like cordova-ios 6 oder newer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek merged pull request #186: docs: Deprecation notice
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #186:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org