You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Grzegorz Grzybek <no...@github.com> on 2014/03/24 17:06:45 UTC

[jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Features which had only bundles with `dependency=&#39;true&#39;` (they wouldn&#39;t install in Karaf):
* jclouds-api-rackspace-cloudidentity
* jclouds-api-rackspace-clouddns
You can merge this Pull Request by running:

  git pull https://github.com/grgrzybek/jclouds-karaf JCLOUDS-511

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-karaf/pull/40

-- Commit Summary --

  * [JCLOUDS-511] Correcting features with dependency-only bundles

-- File Changes --

    M feature/src/main/resources/feature.xml (5)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/40.patch
https://github.com/jclouds/jclouds-karaf/pull/40.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Andrew Phillips <no...@github.com>.
Closed #40.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Ioannis Canellos <no...@github.com>.
Apparently, when I split the rackspace features into pieces I forgot to remove the dependency attribute from cloud identity/dns. Having a feature that only defines "dependencies" without defining anything else is wrong as it will fail to install the required stuff in an environment that is using a resolver.

So, here is my +1
 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38551896

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;h=b21a335). Thanks, @grgrzybek!

@iocanel: Do we want to backport this to e.g. 1.7.x?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-39008909

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-karaf-pull-requests #52 UNSTABLE

No test failures, just a bunch of [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/52/violations/). None related to this PR, though, from what I can see.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-39008811

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Everett Toews <no...@github.com>.
@iocanel @nacx Do either of you have an opinion on this?

I know zilch about Karaf.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38491152

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Grzegorz Grzybek <no...@github.com>.
@iocanel see ENTESB-1209 and ENTESB-1210

regards
Grzegorz Grzybek

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38491972

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #52](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/52/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38470276

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-karaf #822](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/822/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38469757

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

Posted by Ioannis Canellos <no...@github.com>.
Yeah we need to back port it.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-39036307