You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/07 10:56:46 UTC
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2053: Refactor `ApiCollector` to simplify deadlock/canceling logic PoC
klesh commented on code in PR #2053:
URL: https://github.com/apache/incubator-devlake/pull/2053#discussion_r891073397
##########
config/config.go:
##########
@@ -69,11 +69,14 @@ func replaceNewEnvItemInOldContent(v *viper.Viper, envFileContent string) (error
switch ret := val.(type) {
case string:
ret = strings.Replace(ret, `\`, `\\`, -1)
- ret = strings.Replace(ret, `=`, `\=`, -1)
- ret = strings.Replace(ret, `'`, `\'`, -1)
+ //ret = strings.Replace(ret, `=`, `\=`, -1)
+ //ret = strings.Replace(ret, `'`, `\'`, -1)
Review Comment:
![image](https://user-images.githubusercontent.com/61080/172363215-322f7963-a35b-49e4-955c-0ff5d1209034.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org