You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/10 03:09:32 UTC

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #140: Adding commit message checker

juzhiyuan opened a new issue #140: Adding commit message checker
URL: https://github.com/apache/incubator-apisix-dashboard/issues/140
 
 
   For the quality of every commit message, please add the Commit Message checker just like [1].
   
   [1] https://github.com/vuejs/vue-next/blob/master/scripts/verifyCommit.js

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #140: Adding commit message checker

Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #140: Adding commit message checker
URL: https://github.com/apache/incubator-apisix-dashboard/issues/140#issuecomment-600534320
 
 
   Okay, how will the script will be invoked ? in the travis configs ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #140: Adding commit message checker

Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #140: Adding commit message checker
URL: https://github.com/apache/incubator-apisix-dashboard/issues/140#issuecomment-600523337
 
 
   Hi @juzhiyuan where exactly this file should be added? in the CI/CD pipeline?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #140: Adding commit message checker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #140: Adding commit message checker
URL: https://github.com/apache/incubator-apisix-dashboard/issues/140#issuecomment-600526363
 
 
   You could create the file under `ROOT/scripts/`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #140: Adding commit message checker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #140: Adding commit message checker
URL: https://github.com/apache/incubator-apisix-dashboard/issues/140#issuecomment-600550321
 
 
   `pre-commit`
   
   This script aims to prevent from writing nonsense commit messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services